Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: add internationalization 🌍 #99

Open
2 tasks done
jvondermarck opened this issue Aug 13, 2023 · 9 comments · May be fixed by #115
Open
2 tasks done

[Feature]: add internationalization 🌍 #99

jvondermarck opened this issue Aug 13, 2023 · 9 comments · May be fixed by #115
Assignees
@RBP98
Labels
difficulty:hard Time-consuming / with design elements enhancement New feature or request good first issue Good for newcomers User Experience Create a something that provides the best possible user experience

Comments

@jvondermarck
Copy link
Collaborator

👉 Please confirm the following

🤔 Is your proposal related to a problem?

No response

😍 Describe the solution you'd like

It would be a good idea to add internationalization. In the menu, the player would be able to select the game's application language. You can add English (default), French, Spanish, German, Russian, and so on... 😍

👍️ Describe alternatives you've considered

We now need to avoid writing the string text in plain text. We must obtain the text to be displayed by obtaining the correct text according to the language chosen by the user.
image

✍ Additional context

No response
@jvondermarck jvondermarck added enhancement New feature or request good first issue Good for newcomers difficulty:hard Time-consuming / with design elements User Experience Create a something that provides the best possible user experience labels Aug 13, 2023
@fnwirth
Copy link

fnwirth commented Jan 28, 2024

I would be happy to assist

@jvondermarck
Copy link
Collaborator Author

Hello @fnwirth, thank you so much, you can contribute to this issue !! :)

@fnwirth
Copy link

fnwirth commented Feb 3, 2024

I created a first draft which so far does not make use of FXGLs own localization feature as I had some trouble using it. However, I could push my draft using an own small class for localization management as a first step once I am added as a contributor to the repository.

@jvondermarck
Copy link
Collaborator Author

Hi @fnwirth, that's really good that you created a first draft ! I can't add you as contributor to the repository, so please refer to our CONTRIBUTING.md, you will need to fork the repository and then submit a Pull Request in this repository. Thank you so much !

@fnwirth fnwirth mentioned this issue Feb 26, 2024
Merged
6 tasks
@jvondermarck
Copy link
Collaborator Author

The issue is still open and needs to be done.

@RBP98
Copy link

RBP98 commented Jul 23, 2024 •
edited
Loading

The issue is still open and needs to be done.

I would like to contribute to this issue

@jvondermarck
Copy link
Collaborator Author

The issue is still open and needs to be done.

I would like to contribute to this issue

Hi, awesome, you can work on it ! 😊

@itsVrushal
Copy link

itsVrushal commented Nov 20, 2024 •
edited
Loading

Hello, could I contribute to the issue? Actually I am new to open source and I might need some assistance but I am willing to help.

@itsVrushal
Copy link

itsVrushal commented Nov 20, 2024 •
edited
Loading

Hello, could i contribute to the issue? Actually i am new to open source and i might need some assistance but i am willing to help.

I have made some changes can i create a pull request?

@itsVrushal itsVrushal linked a pull request Nov 24, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RBP98 RBP98

Labels
difficulty:hard Time-consuming / with design elements enhancement New feature or request good first issue Good for newcomers User Experience Create a something that provides the best possible user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vrushalpatilbranch itsVrushal/dinosaur-exploder
4 participants
@RBP98 @fnwirth @jvondermarck @itsVrushal