Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Adding sounds (SFX) #40

Open
2 tasks done
jvondermarck opened this issue Mar 30, 2022 · 12 comments · Fixed by #66 or #75
Open
2 tasks done

[Feature]: Adding sounds (SFX) #40

jvondermarck opened this issue Mar 30, 2022 · 12 comments · Fixed by #66 or #75
Labels
difficulty:hard Time-consuming / with design elements enhancement New feature or request

Comments

@jvondermarck
Copy link
Collaborator

jvondermarck commented Mar 30, 2022

👉 Please confirm the following

🤔 Is your proposal related to a problem?

No response

😍 Describe the solution you'd like

It would be great to add some sounds to the game :

  • A sound when we will be on the home screen (look at this issue to know if the home screen is available)
  • A sound when we shoot (e.g search for laser shoot sounds)
  • A sound while shooting/kill a dinosaur / sound when dinosaur get hit by the laser
  • A sound in general while playing (e.g a sound link to the space / spaceship noise...)
  • A sound when the player dies (maybe find a spaceship explosion ??)

👍️ Describe alternatives you've considered

Please use OPEN SOURCE sounds (SFX sounds : Free sounds effects).
Be careful to not put too loud the sounds

✍ Additional context

You can send us a picture before doing a pull request, just so we can all agree on the sounds you choose. (Contact us on Discord, GitHub discussions, Twitter, Gmail)

@jvondermarck jvondermarck added the enhancement New feature or request label Mar 30, 2022
@jvondermarck jvondermarck changed the title [Feature]: Adding sounds [Feature]: Adding sounds (SFX) Mar 30, 2022
@jvondermarck
Copy link
Collaborator Author

I found on the FXGL documentation a section on how to add sounds, maybe it can help you :)

@jvondermarck jvondermarck added the difficulty:hard Time-consuming / with design elements label May 7, 2022
@kiancliffe
Copy link
Contributor

Hi @jvondermarck I would like to give this a go for a few sounds I made in sfxr, can you assign it to me please :)

@jvondermarck
Copy link
Collaborator Author

Hii, @kiancliffe I'm glad if you can take this issue ! Thank you so much !

This was referenced May 22, 2022
@jvondermarck jvondermarck reopened this Jun 10, 2022
@jvondermarck
Copy link
Collaborator Author

Add a home screen background sound :
image

@nadia12-p
Copy link
Contributor

nadia12-p commented Jul 6, 2022

Hi @jvondermarck, if the issue is free, can I continue working on this? I think maybe a sound when you're playing the game would also be nice to implement, what do you think?

@jvondermarck
Copy link
Collaborator Author

Hi @nadia12-p that's a great idea, absolutely you can work on this issue, thank you very much! 🙏 (btw I'll review ur PR asap)

@nadia12-p
Copy link
Contributor

Hi @nadia12-p that's a great idea, absolutely you can work on this issue, thank you very much! 🙏 (btw I'll review ur PR asap)

Yeah no worries take your time!! Meanwhile I'll work on this :D

@jvondermarck
Copy link
Collaborator Author

Great @nadia12-p , good luck, if you have any questions or need help to choose between different SFX do not hesitate :)

@nadia12-p
Copy link
Contributor

nadia12-p commented Jul 7, 2022

Hi @jvondermarck ! yeah actually I'm choosing the sounds from this website. I chose this sound for the Home Screen (sorry for the picture, the website doesn't let me link it :P):

Screen Shot 2022-07-07 at 15 14 08

I'm using the first 40 seconds on repeat though because I didn't like the rest of the audio, let me know if you like it or I should switch it :D

Another thing, I realized we already have a sound when the user is playing the game, it's a file called engine.wav. On the website with the sounds I've found another that I liked for the background when the game is running, this one:

Screen Shot 2022-07-07 at 15 17 12

However, I'm having trouble playing both sounds (engine.wav and the sound from the website at the same time). But I wanted your opinion, should both sounds be playing or do you prefer one over the other? Let me know! :)

(sorry for the long reply lol)

@jvondermarck
Copy link
Collaborator Author

Hi @nadia12-p, I like both songs !!
I also found this sound, it's a spaceship sound so it can be great for the game as well :
image

I think u can remove the sound engine.wav because we don't really hear it when we play, so put in place of this engine.wav sound, the sound you want, it's up to you ! The most important thing is to have a good user experience for the player, to be best immersed in the game world :)

@nadia12-p
Copy link
Contributor

Hey @jvondermarck good to know! I'll add the sound and submit the PR asap :D

@nadia12-p nadia12-p mentioned this issue Jul 8, 2022
6 tasks
@jvondermarck
Copy link
Collaborator Author

jvondermarck commented Jul 10, 2022

It would be great to add a sound when the player dies (maybe find a spaceship explosion ??) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:hard Time-consuming / with design elements enhancement New feature or request
Projects
None yet
3 participants