Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Adjust the sound volume while playing #112

Open
2 tasks done
jvondermarck opened this issue Aug 26, 2024 · 2 comments · May be fixed by #114
Open
2 tasks done

[Feature]: Adjust the sound volume while playing #112

jvondermarck opened this issue Aug 26, 2024 · 2 comments · May be fixed by #114
Assignees
Labels
difficulty:medium Need time to think through good first issue Good for newcomers User Experience Create a something that provides the best possible user experience

Comments

@jvondermarck
Copy link
Collaborator

👉 Please confirm the following

🤔 Is your proposal related to a problem?

So far we can only mute / unmute and adjust with a slide bar the sound of the home screen but not the sound when we play the game.

😍 Describe the solution you'd like

  • Be able to mute / unmute
  • Adjust the sound with a slide bar

👍️ Describe alternatives you've considered

  • When we press the key "ESC" to pause the game, it would be great to adjust the sound there.
    image

✍ Additional context

Feel free to adjust as you want but try to do something that looks good for a great User Experience :)

@jvondermarck jvondermarck added good first issue Good for newcomers difficulty:medium Need time to think through User Experience Create a something that provides the best possible user experience labels Aug 26, 2024
@CGaneshKumar2002
Copy link
Contributor

Hi @jvondermarck I'm willing to work on this issue. I'd appreciate if you assign this to me. Thanks!

@CGaneshKumar2002
Copy link
Contributor

Hey @jvondermarck
I've raised a PR for this issue. Kindly check and let me know if you have feedback. I'll be glad if you add the label "hacktoberfest-accepted" to my PR too! Thanks in advance

PR Link:
#114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium Need time to think through good first issue Good for newcomers User Experience Create a something that provides the best possible user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@jvondermarck @CGaneshKumar2002 and others