From c693502c57addf9ccf116afa5269ddb61c163ce3 Mon Sep 17 00:00:00 2001 From: Teddy Ding Date: Fri, 22 Nov 2024 10:18:11 -0500 Subject: [PATCH 1/3] Enable OE by default --- protocol/app/flags/flags.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/app/flags/flags.go b/protocol/app/flags/flags.go index b166f88352..1a0ad084e1 100644 --- a/protocol/app/flags/flags.go +++ b/protocol/app/flags/flags.go @@ -80,7 +80,7 @@ const ( DefaultVEOracleEnabled = true - DefaultOptimisticExecutionEnabled = false + DefaultOptimisticExecutionEnabled = true DefaultOptimisticExecutionTestAbortRate = 0 ) From cd6c7cb6acb187a69fa91dfd03d111b342280a3a Mon Sep 17 00:00:00 2001 From: Teddy Ding Date: Sat, 23 Nov 2024 22:29:56 -0500 Subject: [PATCH 2/3] Dont use OE in TestApp --- protocol/testutil/app/app.go | 1 + 1 file changed, 1 insertion(+) diff --git a/protocol/testutil/app/app.go b/protocol/testutil/app/app.go index a4dbac0bc2..a5640ce8c7 100644 --- a/protocol/testutil/app/app.go +++ b/protocol/testutil/app/app.go @@ -1308,6 +1308,7 @@ func launchValidatorInDir( "--oracle.enabled=false", "--oracle.metrics_enabled=false", "--log_level=error", + "--optimistic-execution-enabled=false", }) ctx := svrcmd.CreateExecuteContext(parentCtx) From 706576b380a26edcbbdaecaacf0fbb83a7018774 Mon Sep 17 00:00:00 2001 From: Teddy Ding Date: Sun, 24 Nov 2024 13:36:27 -0500 Subject: [PATCH 3/3] Add comment --- protocol/testutil/app/app.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/protocol/testutil/app/app.go b/protocol/testutil/app/app.go index a5640ce8c7..69d76021f3 100644 --- a/protocol/testutil/app/app.go +++ b/protocol/testutil/app/app.go @@ -1308,6 +1308,8 @@ func launchValidatorInDir( "--oracle.enabled=false", "--oracle.metrics_enabled=false", "--log_level=error", + // TODO(CT-1329): Currently, the TestApp framework does not work well with OE, + // since the non-deterministic test app instances does not handle go routines. "--optimistic-execution-enabled=false", })