From 86e82e80110684f4a995b491b699ecadd7db6dd8 Mon Sep 17 00:00:00 2001 From: Prashan Dharmasena <163016611+prashanDYDX@users.noreply.github.com> Date: Mon, 29 Apr 2024 18:39:09 -0400 Subject: [PATCH] Turn off InvalidPackageDeclaration Detekt rule (#321) --- detekt-baseline.xml | 233 -------------------------------------------- detekt.yml | 6 ++ 2 files changed, 6 insertions(+), 233 deletions(-) diff --git a/detekt-baseline.xml b/detekt-baseline.xml index 7408943d6..e617e2453 100644 --- a/detekt-baseline.xml +++ b/detekt-baseline.xml @@ -84,7 +84,6 @@ ComplexCondition:TriggerOrdersInput.kt$TriggerOrdersInput.Companion$existing?.marketId != marketId || existing?.size != size || existing?.stopLossOrder != stopLossOrder || existing?.takeProfitOrder != takeProfitOrder ComplexCondition:TriggerOrdersInput.kt$TriggerPrice.Companion$existing?.limitPrice != limitPrice || existing?.triggerPrice != triggerPrice || existing?.percentDiff != percentDiff || existing?.usdcDiff != usdcDiff || existing?.input != input ComplexCondition:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$size == null || size == Numeric.double.ZERO || notionalTotal == Numeric.double.ZERO || leverage == Numeric.double.ZERO - ComplexCondition:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$!isShortTermAndRequiresImmediateExecution && (status == "OPEN" || status == "PENDING" || status == "UNTRIGGERED" || status == "PARTIALLY_FILLED") ComplexCondition:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$triggerPrice != null && triggerPrice <= 0 || (limitPrice != null && limitPrice <= 0) ComplexCondition:V4StateManagerAdaptor+Transfer.kt$fromChain != null && fromToken != null && fromAmount != null && fromAmount > 0 && fromAmountString != null && accountAddress != null && chainId != null && dydxTokenDemon != null && url != null && sourceAddress != null && squidIntegratorId != null ComplexCondition:V4StateManagerAdaptor+Transfer.kt$fromChain != null && fromToken != null && fromAmount != null && fromAmount > 0 && fromAmountString != null && nobleAddress != null && chainId != null && dydxTokenDemon != null && url != null && sourceAddress != null && squidIntegratorId != null && toChain != null && toToken != null @@ -353,206 +352,6 @@ FunctionOnlyReturningConstant:V4StateManagerConfigs.kt$V4StateManagerConfigs$fun nobleDenom(): String? FunctionParameterNaming:AsyncAbacusStateManager.kt$AsyncAbacusStateManager.Companion$_nativeImplementations: ProtocolNativeImpFactory FunctionParameterNaming:AsyncAbacusStateManagerV2.kt$AsyncAbacusStateManagerV2.Companion$_nativeImplementations: ProtocolNativeImpFactory - InvalidPackageDeclaration:AbacusHelper.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:Account.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:AccountCalculator.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:AccountInputValidator.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:AccountProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:AccountSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:AccountTransformer.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:AccountsSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:AddressFormatException.kt$package exchange.dydx.abacus.utils.beth32 - InvalidPackageDeclaration:AnalyticsUtils.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:ApiUtils.kt$package exchange.dydx.abacus.state.app.adaptors - InvalidPackageDeclaration:Asset.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:AssetPositionProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:AssetPositionsProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:AssetProcessor.kt$package exchange.dydx.abacus.processor.assets - InvalidPackageDeclaration:AssetsProcessor.kt$package exchange.dydx.abacus.processor.assets - InvalidPackageDeclaration:AsyncAbacusStateManager.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:AsyncAbacusStateManagerProtocol.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:AsyncAbacusStateManagerV2.kt$package exchange.dydx.abacus.state.v2.manager - InvalidPackageDeclaration:BaseInputValidator.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:BaseProcessor.kt$package exchange.dydx.abacus.processor.base - InvalidPackageDeclaration:Bech32.kt$package exchange.dydx.abacus.utils.beth32 - InvalidPackageDeclaration:Bech32Data.kt$package exchange.dydx.abacus.utils.beth32 - InvalidPackageDeclaration:CandleProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:CandlesProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:CctpChainTokenInfo.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:ClosePositionInput.kt$package exchange.dydx.abacus.output.input - InvalidPackageDeclaration:Compliance.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:Configs.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:Configs.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:ConfigsProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:ConnectionStats.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:ConnectionsSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:Constants.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:DepositValidator.kt$package exchange.dydx.abacus.validator.transfer - InvalidPackageDeclaration:Documentation.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:DynamicLocalizer.kt$package exchange.dydx.abacus.state.app.helper - InvalidPackageDeclaration:Enviroment.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:EquityTierProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:EquityTiersProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:ExchangeInfo.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:FeeDiscountProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:FeeDiscountsProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:FeeTierProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:FeeTiersProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:FieldsInputValidator.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:FillProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:FillsProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:Formatter.kt$package exchange.dydx.abacus.state.app.helper - InvalidPackageDeclaration:FundingPaymentProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:FundingPaymentsProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:GoodTil.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:HistoricalFundingProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:HistoricalFundingsProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:HistoricalPNLProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:HistoricalPNLsProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:HistoricalTradingRewardProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:HistoricalTradingRewardsProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:Input.kt$package exchange.dydx.abacus.output.input - InvalidPackageDeclaration:InputValidator.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:JsonEncoder.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:JsonUtils.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:LaunchIncentive.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:LaunchIncentivePointProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:LaunchIncentivePointsProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:LaunchIncentiveProcessor.kt$package exchange.dydx.abacus.processor.launchIncentive - InvalidPackageDeclaration:LaunchIncentiveSeasonProcessor.kt$package exchange.dydx.abacus.processor.launchIncentive - InvalidPackageDeclaration:LaunchIncentiveSeasonsProcessor.kt$package exchange.dydx.abacus.processor.launchIncentive - InvalidPackageDeclaration:LimiterCapacitiesProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:LimiterCapacityProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:List+Utils.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:LocalizerProtocol.kt$package exchange.dydx.abacus.protocols - InvalidPackageDeclaration:Logger.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:LoggerProtocol.kt$package exchange.dydx.abacus.protocols - InvalidPackageDeclaration:Map+Utils.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:Market.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:MarketCalculator.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:MarketId.kt$package exchange.dydx.abacus.processor.utils - InvalidPackageDeclaration:MarketProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:MarketSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:MarketsProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:MarketsSummaryProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:MarketsSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:Address.kt$package exchange.dydx.abacus.state.manager.utils - InvalidPackageDeclaration:Network.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:NetworkConfigsProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:NetworkHelper.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:NetworkSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:Notification.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:NotificationsProvider.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:Numeric.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:OnboardingSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:OrderProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:OrderTypeProcessor.kt$package exchange.dydx.abacus.processor.utils - InvalidPackageDeclaration:OrderbookEntryProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:OrderbookProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:OrdersProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:Parser.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:ParserProtocol.kt$package exchange.dydx.abacus.protocols - InvalidPackageDeclaration:ParsingError.kt$package exchange.dydx.abacus.responses - InvalidPackageDeclaration:ParsingHelper.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:Payloads.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:PerpTradingStateMachine.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:PerpetualPositionProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:PerpetualPositionsProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:PerpetualState.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:ProtocolNativeImpFactory.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:PublicProtocols.kt$package exchange.dydx.abacus.protocols - InvalidPackageDeclaration:RegulatoryRestriction.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:RewardsProcessor.kt$package exchange.dydx.abacus.processor - InvalidPackageDeclaration:Rounder.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:SerializableCollections.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:ServerTime.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:Set+Utils.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:Settings.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:SquidChainProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidChainResourceProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidRoutePayloadProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidRouteProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidRouteV2PayloadProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidRouteV2Processor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidStatusProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidTokenProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:SquidTokenResourceProcessor.kt$package exchange.dydx.abacus.processor.squid - InvalidPackageDeclaration:StateChanges.kt$package exchange.dydx.abacus.state.changes - InvalidPackageDeclaration:StateManagerAdaptor.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:StateManagerAdaptorV2.kt$package exchange.dydx.abacus.state.v2.manager - InvalidPackageDeclaration:StateManagerConfigs.kt$package exchange.dydx.abacus.state.manager.configs - InvalidPackageDeclaration:StateResponse.kt$package exchange.dydx.abacus.responses - InvalidPackageDeclaration:String+Utils.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:StringHelper.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:SubaccountCalculator.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:SubaccountSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:SubaccountTransformer.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:SystemSupervisor.kt$package exchange.dydx.abacus.state.v2.supervisor - InvalidPackageDeclaration:SystemUtils.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:Threading.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:Timer.kt$package exchange.dydx.abacus.utils - InvalidPackageDeclaration:TradeAccountStateValidator.kt$package exchange.dydx.abacus.validator.trade - InvalidPackageDeclaration:TradeBracketOrdersValidator.kt$package exchange.dydx.abacus.validator.trade - InvalidPackageDeclaration:TradeInput.kt$package exchange.dydx.abacus.output.input - InvalidPackageDeclaration:TradeInputCalculator.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:TradeInputDataValidator.kt$package exchange.dydx.abacus.validator.trade - InvalidPackageDeclaration:TradeInputValidator.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:TradeMarketOrderInputValidator.kt$package exchange.dydx.abacus.validator.trade - InvalidPackageDeclaration:TradePositionStateValidator.kt$package exchange.dydx.abacus.validator.trade - InvalidPackageDeclaration:TradeProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:TradeTriggerPriceValidator.kt$package exchange.dydx.abacus.validator.trade - InvalidPackageDeclaration:TradesProcessor.kt$package exchange.dydx.abacus.processor.markets - InvalidPackageDeclaration:TradingStateMachine+Account.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Candles.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+ClosePositionInput.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+EquityTiers.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Errors.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+FeeDiscounts.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+FeeTiers.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+HistoricalFunding.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+HistoricalPnl.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+HistoricalTradingRewards.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+LaunchIncentive.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Markets.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Orderbook.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+ParentSubaccount.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Rewards.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Squid.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+TradeInput.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Trades.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+TransferInput.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+TriggerOrdersInput.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+Wallet.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine+WithdrawalGating.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStateMachine.kt$package exchange.dydx.abacus.state.model - InvalidPackageDeclaration:TradingStates.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:TransactionQueue.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:TransferInput.kt$package exchange.dydx.abacus.output.input - InvalidPackageDeclaration:TransferInputCalculator.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:TransferInputValidator.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:TransferOutValidator.kt$package exchange.dydx.abacus.validator.transfer - InvalidPackageDeclaration:TransferProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:TransferStatus.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:TransfersProcessor.kt$package exchange.dydx.abacus.processor.wallet.account - InvalidPackageDeclaration:TriggerOrdersInput.kt$package exchange.dydx.abacus.output.input - InvalidPackageDeclaration:TriggerOrdersInputCalculator.kt$package exchange.dydx.abacus.calculator - InvalidPackageDeclaration:TriggerOrdersInputValidator.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:UserProcessor.kt$package exchange.dydx.abacus.processor.wallet.user - InvalidPackageDeclaration:V3AccountProcessor.kt$package exchange.dydx.abacus.processor.wallet.account.deprecated - InvalidPackageDeclaration:V3ApiKey.kt$package exchange.dydx.abacus.state.app.signer - InvalidPackageDeclaration:V4StateManagerAdaptor+Transfer.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:V4StateManagerAdaptor.kt$package exchange.dydx.abacus.state.manager - InvalidPackageDeclaration:V4StateManagerConfigs.kt$package exchange.dydx.abacus.state.manager.configs - InvalidPackageDeclaration:V4TransactionErrors.kt$package exchange.dydx.abacus.state.app.adaptors - InvalidPackageDeclaration:ValidationError.kt$package exchange.dydx.abacus.output.input - InvalidPackageDeclaration:ValidatorProtocols.kt$package exchange.dydx.abacus.validator - InvalidPackageDeclaration:Wallet.kt$package exchange.dydx.abacus.output - InvalidPackageDeclaration:WalletProcessor.kt$package exchange.dydx.abacus.processor.wallet - InvalidPackageDeclaration:WithdrawalCapacityProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:WithdrawalCapacityValidator.kt$package exchange.dydx.abacus.validator.transfer - InvalidPackageDeclaration:WithdrawalGatingProcessor.kt$package exchange.dydx.abacus.processor.configs - InvalidPackageDeclaration:WithdrawalGatingValidator.kt$package exchange.dydx.abacus.validator.transfer LargeClass:AccountSupervisor.kt$AccountSupervisor : DynamicNetworkSupervisor LargeClass:OnboardingSupervisor.kt$OnboardingSupervisor : NetworkSupervisor LargeClass:StateManagerAdaptor.kt$StateManagerAdaptor @@ -815,22 +614,13 @@ MagicNumber:SubaccountSupervisor.kt$SubaccountSupervisor$28.0 MagicNumber:TradeInputCalculator.kt$TradeInputCalculator$0.00001 MagicNumber:TradeInputCalculator.kt$TradeInputCalculator$0.001 - MagicNumber:TradeInputCalculator.kt$TradeInputCalculator$0.01 - MagicNumber:TradeInputCalculator.kt$TradeInputCalculator$0.05 - MagicNumber:TradeInputCalculator.kt$TradeInputCalculator$0.1 - MagicNumber:TradeInputCalculator.kt$TradeInputCalculator$0.2 MagicNumber:TradeInputCalculator.kt$TradeInputCalculator$28 - MagicNumber:TradeInputDataValidator.kt$TradeInputDataValidator$20 MagicNumber:TradeMarketOrderInputValidator.kt$TradeMarketOrderInputValidator$0.05 MagicNumber:TradeMarketOrderInputValidator.kt$TradeMarketOrderInputValidator$0.1 MagicNumber:TradesProcessor.kt$TradesProcessor$500 MagicNumber:TransferInputCalculator.kt$TransferInputCalculator$100.0 - MagicNumber:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$0.05 - MagicNumber:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$0.1 - MagicNumber:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$0.2 MagicNumber:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$100 MagicNumber:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$100.0 - MagicNumber:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$20 MagicNumber:V4StateManagerAdaptor.kt$V4StateManagerAdaptor$1.5 MagicNumber:V4StateManagerAdaptor.kt$V4StateManagerAdaptor$10.0 MagicNumber:V4StateManagerAdaptor.kt$V4StateManagerAdaptor$18 @@ -906,16 +696,7 @@ MaxLineLength:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$if MaxLineLength:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$private MaxLineLength:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$val triggerPrices = parser.asNativeMap(triggerOrder["price"])?.let { calculateTriggerPrices(it, position, absSize) } - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$(status == "OPEN" || status == "PENDING" || status == "UNTRIGGERED" || status == "PARTIALLY_FILLED") MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT" || type == "STOP_MARKET") "ERRORS.TRIGGERS_FORM.STOP_LOSS_TRIGGER_MUST_ABOVE_INDEX_PRICE" else "ERRORS.TRIGGERS_FORM.TAKE_PROFIT_TRIGGER_MUST_ABOVE_INDEX_PRICE" - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT" || type == "STOP_MARKET") "ERRORS.TRIGGERS_FORM.STOP_LOSS_TRIGGER_MUST_BELOW_INDEX_PRICE" else "ERRORS.TRIGGERS_FORM.TAKE_PROFIT_TRIGGER_MUST_BELOW_INDEX_PRICE" - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT" || type == "STOP_MARKET") "ERRORS.TRIGGERS_FORM_TITLE.STOP_LOSS_TRIGGER_MUST_ABOVE_INDEX_PRICE" else "ERRORS.TRIGGERS_FORM_TITLE.TAKE_PROFIT_TRIGGER_MUST_ABOVE_INDEX_PRICE" - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT" || type == "STOP_MARKET") "ERRORS.TRIGGERS_FORM_TITLE.STOP_LOSS_TRIGGER_MUST_BELOW_INDEX_PRICE" else "ERRORS.TRIGGERS_FORM_TITLE.TAKE_PROFIT_TRIGGER_MUST_BELOW_INDEX_PRICE" - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT") "ERRORS.TRIGGERS_FORM.STOP_LOSS_LIMIT_MUST_ABOVE_TRIGGER_PRICE" else "ERRORS.TRIGGERS_FORM.TAKE_PROFIT_LIMIT_MUST_ABOVE_TRIGGER_PRICE" - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT") "ERRORS.TRIGGERS_FORM.STOP_LOSS_LIMIT_MUST_BELOW_TRIGGER_PRICE" else "ERRORS.TRIGGERS_FORM.TAKE_PROFIT_LIMIT_MUST_BELOW_TRIGGER_PRICE" - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT") "ERRORS.TRIGGERS_FORM_TITLE.STOP_LOSS_LIMIT_MUST_ABOVE_TRIGGER_PRICE" else "ERRORS.TRIGGERS_FORM_TITLE.TAKE_PROFIT_LIMIT_MUST_ABOVE_TRIGGER_PRICE" - MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$if (type == "STOP_LIMIT") "ERRORS.TRIGGERS_FORM_TITLE.STOP_LOSS_LIMIT_MUST_BELOW_TRIGGER_PRICE" else "ERRORS.TRIGGERS_FORM_TITLE.TAKE_PROFIT_LIMIT_MUST_BELOW_TRIGGER_PRICE" MaxLineLength:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$} MaxLineLength:V4StateManagerAdaptor.kt$V4StateManagerAdaptor$"{\"operationName\":\"TradingSeasons\",\"variables\":{},\"query\":\"query TradingSeasons {tradingSeasons {startTimestamp label __typename }}\"}" MaxLineLength:V4StateManagerAdaptor.kt$V4StateManagerAdaptor$if (isCancel) AnalyticsEvent.TradeCancelOrderClick.rawValue else AnalyticsEvent.TradePlaceOrderClick.rawValue @@ -1320,7 +1101,6 @@ UnusedParameter:TradeInputValidator.kt$TradeInputValidator$trade: Map<String, Any> UnusedParameter:TradeMarketOrderInputValidator.kt$TradeMarketOrderInputValidator$markets: Map<String, Any>? UnusedParameter:TradePositionStateValidator.kt$TradePositionStateValidator$restricted: Boolean - UnusedParameter:TradeTriggerPriceValidator.kt$TradeTriggerPriceValidator$parser: ParserProtocol UnusedParameter:TradingStateMachine+Orderbook.kt$payload: Map<String, Any> UnusedParameter:TradingStateMachine+TriggerOrdersInput.kt$triggerOrders: Map<String, Any> UnusedParameter:TradingStateMachine+TriggerOrdersInput.kt$typeText: String? @@ -1372,7 +1152,6 @@ UnusedPrivateProperty:StringHelper.kt$StringHelper.Companion$i UnusedPrivateProperty:SubaccountSupervisor.kt$SubaccountSupervisor$val transferType = transfer.type UnusedPrivateProperty:TradeInput.kt$TradeInputOptions.Companion$private val typeOptionsArray = iListOf( SelectionOption( OrderType.limit.rawValue, null, "APP.TRADE.LIMIT_ORDER_SHORT", null, ), SelectionOption( OrderType.market.rawValue, null, "APP.TRADE.MARKET_ORDER_SHORT", null, ), SelectionOption(OrderType.stopLimit.rawValue, null, "APP.TRADE.STOP_LIMIT", null), SelectionOption(OrderType.stopMarket.rawValue, null, "APP.TRADE.STOP_MARKET", null), SelectionOption( OrderType.trailingStop.rawValue, null, "APP.TRADE.TRAILING_STOP", null, ), SelectionOption( OrderType.takeProfitLimit.rawValue, null, "APP.TRADE.TAKE_PROFIT", null, ), SelectionOption( OrderType.takeProfitMarket.rawValue, null, "APP.TRADE.TAKE_PROFIT_MARKET", null, ), ) - UnusedPrivateProperty:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val MARKET_ORDER_SLIPPAGE_WARNING_THRESHOLD = 0.01 UnusedPrivateProperty:TradePositionStateValidator.kt$TradePositionStateValidator$val closeOnlyError = validateCloseOnly( market, change, ) UnusedPrivateProperty:TradingStateMachine.kt$TradingStateMachine$val startTime = now - days.days UtilityClassWithPublicConstructor:AbacusHelper.kt$AbacusHelper @@ -1398,12 +1177,6 @@ VariableNaming:Numeric.kt$Doubles$@Suppress("PropertyName") val ZERO = 0.0 VariableNaming:StateManagerAdaptor.kt$StateManagerAdaptor$@Suppress("LocalVariableName", "PropertyName") private val TRIGGER_ORDER_DEFAULT_DURATION_DAYS = 28.0 VariableNaming:SubaccountSupervisor.kt$SubaccountSupervisor$@Suppress("LocalVariableName", "PropertyName") private val TRIGGER_ORDER_DEFAULT_DURATION_DAYS = 28.0 - VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val MARKET_ORDER_MAX_SLIPPAGE = 0.05 - VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val MARKET_ORDER_SLIPPAGE_WARNING_THRESHOLD = 0.01 - VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val STOP_MARKET_ORDER_SLIPPAGE_BUFFER = 0.1 - VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val STOP_MARKET_ORDER_SLIPPAGE_BUFFER_MAJOR_MARKET = 0.05 - VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val TAKE_PROFIT_MARKET_ORDER_SLIPPAGE_BUFFER = 0.2 - VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val TAKE_PROFIT_MARKET_ORDER_SLIPPAGE_BUFFER_MAJOR_MARKET = 0.1 VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") val FR = parser.asDouble(feeRate)!! VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") val LV = parser.asDouble(leverage)!! VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") val MP = entryPrice @@ -1412,14 +1185,8 @@ VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") val X = ((LV * AE) - (SZ * OR)) / (OR + (OS * LV * MP * FR) - (LV * (OR - MP))) VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") var AE = parser.asDouble(equity)!! VariableNaming:TradeInputCalculator.kt$TradeInputCalculator$@Suppress("LocalVariableName", "PropertyName") var SZ = parser.asDouble(positionSize) ?: Numeric.double.ZERO - VariableNaming:TradeInputDataValidator.kt$TradeInputDataValidator$@Suppress("PropertyName") private val MAX_NUM_OPEN_UNTRIGGERED_ORDERS: Int = 20 VariableNaming:TradeMarketOrderInputValidator.kt$TradeMarketOrderInputValidator$@Suppress("LocalVariableName", "PropertyName") private val MARKET_ORDER_ERROR_SLIPPAGE = 0.1 VariableNaming:TradeMarketOrderInputValidator.kt$TradeMarketOrderInputValidator$@Suppress("LocalVariableName", "PropertyName") private val MARKET_ORDER_WARNING_SLIPPAGE = 0.05 VariableNaming:TradesProcessor.kt$TradesProcessor$@Suppress("PropertyName") private val LIMIT = 500 - VariableNaming:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val STOP_MARKET_ORDER_SLIPPAGE_BUFFER = 0.1 - VariableNaming:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val STOP_MARKET_ORDER_SLIPPAGE_BUFFER_MAJOR_MARKET = 0.05 - VariableNaming:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val TAKE_PROFIT_MARKET_ORDER_SLIPPAGE_BUFFER = 0.2 - VariableNaming:TriggerOrdersInputCalculator.kt$TriggerOrdersInputCalculator$@Suppress("LocalVariableName", "PropertyName") private val TAKE_PROFIT_MARKET_ORDER_SLIPPAGE_BUFFER_MAJOR_MARKET = 0.1 - VariableNaming:TriggerOrdersInputValidator.kt$TriggerOrdersInputValidator$@Suppress("PropertyName") private val MAX_NUM_OPEN_UNTRIGGERED_ORDERS: Int = 20 diff --git a/detekt.yml b/detekt.yml index e69de29bb..5292364d2 100644 --- a/detekt.yml +++ b/detekt.yml @@ -0,0 +1,6 @@ +naming: + InvalidPackageDeclaration: + # some of our package folders are structured /exchange.dydx.abacus instead of: + # /exchange -> /dydx -> /abacus + # didn't seem worth the potential thrash in PRs to fix (feel free to fix if you feel differently) + active: false \ No newline at end of file