-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Draco compression to mbgrd2gltf #1426
Comments
Mike,
Feel free to augment the code and commit it. Draco seems to be available in MacPorts and Ubuntu.
Cheers,
Dave
… On Jan 20, 2024, at 1:14 PM, Mike McCann ***@***.***> wrote:
[POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.]
Following up on #1257 <#1257> it would be great to have the default output of mbgrd2gltf be a compressed mesh. The open source Draco library (https://github.com/google/draco) seems appropriate for providing this new feature.
An experiment with using draco_transcode showed a 60x decrease in file size for the Monterey25 terrain <stoqs/stoqs#1175 (comment)>:
➜ draco_transcoder -i Monterey25_e10_lat_rev.glb -o Monterey25_e10_lat_rev_drc.glb
Transcode Monterey25_e10_lat_rev.glb 7645
➜ ls -lh Monterey25_e10_lat_rev*
-rw-r--r--@ 1 mccann 513 237M Jan 20 12:50 Monterey25_e10_lat_rev.glb
-rw-r--r--@ 1 mccann 513 3.8M Jan 20 12:51 Monterey25_e10_lat_rev_drc.glb
We can convert to Draco compressed gltf following execution of mbgrd2gltf using draco_transcoder but it would be much nicer to have mbgrd2gltf write Draco compressed gltf to begin with as the file size reduction is significant.
—
Reply to this email directly, view it on GitHub <#1426>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTSXXDAKOQZMUODX3J3N6LYPQXUJAVCNFSM6AAAAABCDOOGT2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TEMRUGI2DMMI>.
You are receiving this because you are subscribed to this thread.
----------------------------------------------------
David W. Caress
Principal Engineer
Seafloor Mapping Lab
Monterey Bay Aquarium Research Institute
7700 Sandholdt Road
Moss Landing, CA 95039
***@***.***
http://www.mbari.org/~caress/
Phone: 831-775-1775
|
Dave, Thanks! I'm expecting to have a capstone team work on this Issue. The idea is to have more manageable smaller files so that we can use the output for 3D terrain displays in the Seafloor Mapping Database and STOQS web apps using x3dom. -Mike |
Mike,
Ok.
Currently there is both a new CMake build system and an old Autotools build system. The Autotools is kept around for building on legacy OSs. I’m going to remove the building of mbgrd2gltf from the Autotools because I don’t want to introduce a new library dependency onto legacy OSs. When your team works on this they should only be modifying the CMakeList.txt files, and not touch Makefile.am or configure.ac files, and not using the configure script You should test using only cmake + make to build and install.
Dave
… On Jan 20, 2024, at 3:11 PM, Mike McCann ***@***.***> wrote:
[POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.]
Dave,
Thanks! I'm expecting to have a capstone team work on this Issue. The idea is to have more manageable smaller files so that we can use the output for 3D terrain displays in the Seafloor Mapping Database <https://www.mbari.org/data/seafloor-mapping/> and STOQS <https://www.mbari.org/data/stoqs-data/> web apps using x3dom <https://www.x3dom.org/>.
-Mike
—
Reply to this email directly, view it on GitHub <#1426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTSXXCT6ETTHTW6JXMBSQDYPRFJJAVCNFSM6AAAAABCDOOGT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGM3DANZXGY>.
You are receiving this because you commented.
----------------------------------------------------
David W. Caress
Principal Engineer
Seafloor Mapping Lab
Monterey Bay Aquarium Research Institute
7700 Sandholdt Road
Moss Landing, CA 95039
***@***.***
http://www.mbari.org/~caress/
Phone: 831-775-1775
|
Good Evening, |
Hello @varadpoddar, It's the latter: add draco encoding on the mesh data before generating the gltf file. I look forward to meeting with your fellow team members to discuss the details of this Issue. We can come back here as needed with specific technical comments. -Mike |
Good Evening @MBARIMike, While testing the current dev build for draco compression functionality in mbgrd2gltf, I ran into the following error with 2 specific .grd files. Have you encountered the issue on MacOS before? The Monterey25 and Globe_1M .grd files seem unaffected. Are there any prep steps that can be performed as I want to try to establish compression using samples from the MGDS Map View. Thank You. |
Hi @varadpoddar, See the gist referred to in #1456 for suggestions on dealing with different forms of metadata in .grd files. With respect to using grids from the MGDS site (a nice thing to be able to do!) we need to first get the grids in geographic (longitude/latitude) coordinates. From my reading of the GMT documentation this command should "unproject" the UTM grids from the MGDS Map View into geographic coordinates that mbgrd2gtlf can operate on:
However, the z array in the resulting file contains no valid data:
Maybe I'm missing some option in the |
Following up on #1257 it would be great to have the default output of
mbgrd2gltf
be a compressed mesh. The open source Draco library (https://github.com/google/draco) seems appropriate for providing this new feature.An experiment with using
draco_transcode
showed a 60x decrease in file size for the Monterey25 terrain:We can convert to Draco compressed gltf following execution of
mbgrd2gltf
usingdraco_transcoder
but it would be much nicer to havembgrd2gltf
write Draco compressed gltf to begin with as the file size reduction is significant.The text was updated successfully, but these errors were encountered: