Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in blockchain documentation #7448

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix typos in blockchain documentation #7448

merged 2 commits into from
Jan 13, 2025

Conversation

Dahka2321
Copy link
Contributor

Changes Made

  1. Fixed table name reference in ronin_docs_block.md:
  • roninm.creation_traces → ronin.creation_traces
  1. Fixed grammar in polygon_base_sources.yml:
  • "contract's deployed" → "contracts deployed"

Why These Changes Are Needed

These corrections improve documentation accuracy by:

  • Fixing incorrect table name reference
  • Correcting grammatical error in contract deployment description

The changes ensure proper table references and maintain professional documentation quality.

Files Changed

  • sources/_base_sources/evm/ronin_docs_block.md
  • sources/_base_sources/evm/polygon_base_sources.yml

@github-actions github-actions bot marked this pull request as draft January 9, 2025 18:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added the WIP work in progress label Jan 9, 2025
@Dahka2321
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Dahka2321 Dahka2321 marked this pull request as ready for review January 9, 2025 18:37
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 9, 2025
github-actions bot added a commit that referenced this pull request Jan 9, 2025
@github-actions
@Dahka2321 has signed the CLA in #7448
c0c5695
Hosuke
Hosuke approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @Dahka2321

@Hosuke Hosuke added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jan 13, 2025
@jeff-dude jeff-dude self-assigned this Jan 13, 2025
@jeff-dude jeff-dude merged commit 795e2d4 into duneanalytics:main Jan 13, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke approved these changes

Assignees

@jeff-dude jeff-dude

Labels
ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dahka2321 @Hosuke @jeff-dude