Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init beets daily spells #7430

Merged
merged 31 commits into from
Jan 13, 2025
Merged

Conversation

viniabussafi
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

to be merged after #7399 and #7414


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject dbt: daily covers the Daily dbt subproject labels Jan 7, 2025
@viniabussafi viniabussafi marked this pull request as ready for review January 9, 2025 17:19
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 9, 2025
@github-actions github-actions bot added the dbt: hourly covers the hourly dbt subproject label Jan 9, 2025
@github-actions github-actions bot removed the dbt: hourly covers the hourly dbt subproject label Jan 9, 2025
@viniabussafi
Copy link
Contributor Author

Spells here use balancer_v2 and balancer_v3 macros. Results are tested and are consistent. Ready on my side

@jeff-dude jeff-dude self-assigned this Jan 13, 2025
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jan 13, 2025
@github-actions github-actions bot removed the dbt: dex covers the DEX dbt subproject label Jan 13, 2025
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jan 13, 2025
@jeff-dude jeff-dude merged commit a2c8d3a into duneanalytics:main Jan 13, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: daily covers the Daily dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants