Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Event Models for GMX v2 Project #7195

Conversation

AIDataMaster
Copy link
Contributor

Description:

Upgrade 4 Event Models: OrderCreated, OrderUpdated, PositionFeesCollected and PositionFeesInfo

@AIDataMaster AIDataMaster marked this pull request as draft November 26, 2024 15:00
@AIDataMaster AIDataMaster changed the title Upgrade gmx event models Upgrade Event Models for GMX v2 Project Nov 26, 2024
@AIDataMaster
Copy link
Contributor Author

Commits updated models for the Arbitrum blockchain. The main goal is to verify that we can successfully update models before scaling the process to Avalanche. This implies that the PR will not go through all checks but must create models for the Arbitrum blockchain. Once this is done, we will manually review the tables and then repeat the process for Avalanche.

@0xRobin 0xRobin added WIP work in progress dbt: daily covers the Daily dbt subproject labels Nov 27, 2024
@AIDataMaster AIDataMaster marked this pull request as ready for review November 28, 2024 20:23
@AIDataMaster AIDataMaster marked this pull request as draft November 28, 2024 20:34
@AIDataMaster AIDataMaster marked this pull request as ready for review November 28, 2024 21:02
@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 2, 2024
@jeff-dude jeff-dude self-assigned this Dec 2, 2024
@jeff-dude jeff-dude added ready-for-merging blocked and removed ready-for-review this PR development is complete, please review labels Dec 2, 2024
@jeff-dude
Copy link
Member

marking blocked, until i see if you'd like to explore the incremental design on spells here as well similar to #7187

let me know what you think 🙏

@AIDataMaster
Copy link
Contributor Author

marking blocked, until i see if you'd like to explore the incremental design on spells here as well similar to #7187

let me know what you think 🙏

Let's proceed as follows: We'll merge this PR since it was created to align some of the dbt models with updates to the smart contracts. After that, I will pull all changes from the main branch and add incremental updates in a second PR, where I am working on adding new dbt models and designing incremental changes. Is it fine for you?

@jeff-dude
Copy link
Member

Let's proceed as follows: We'll merge this PR since it was created to align some of the dbt models with updates to the smart contracts. After that, I will pull all changes from the main branch and add incremental updates in a second PR, where I am working on adding new dbt models and designing incremental changes. Is it fine for you?

yep, works for me, thanks!

@jeff-dude jeff-dude added the WIP work in progress label Dec 3, 2024
@jeff-dude
Copy link
Member

we are getting a failure in CI now though, so i'll wait to see that resolved

@AIDataMaster
Copy link
Contributor Author

we are getting a failure in CI now though, so i'll wait to see that resolved

Now it's ready for merge! :) Sometimes, errors occur because the reference model was not updated, resulting in NULL values for columns that cannot be NULL.

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Dec 4, 2024
@jeff-dude jeff-dude merged commit 339f1ea into duneanalytics:main Dec 4, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: daily covers the Daily dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants