Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use magic/constant strings for DB keys #96

Open
mklarz opened this issue Apr 30, 2021 · 0 comments
Open

Use magic/constant strings for DB keys #96

mklarz opened this issue Apr 30, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mklarz
Copy link
Contributor

mklarz commented Apr 30, 2021

It's bad practice to use strings directly instead of via. a constant when it comes to important matching (like DB keys).

We need to replace every occurrence of a DB key with a constant string.

@mklarz mklarz added enhancement New feature or request good first issue Good for newcomers labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant