Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the commands into their own files #88

Open
mklarz opened this issue Apr 27, 2021 · 0 comments
Open

Separate the commands into their own files #88

mklarz opened this issue Apr 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@mklarz
Copy link
Contributor

mklarz commented Apr 27, 2021

We should do some fast clean-up, as we currently have 3 categories of commands. bot.py contains our core commands, ctftime.py contains the commands for ctftime, whilst ctfs.py contains the commands for both the main CTF channel, but also the challenge channels.

I suggest we separate the commands into two files, ctf.py for the commands that are used in the main channel, and challenges.py for the commands used inside a challenge channel.

This would give us a better overview, and since we don't use the bot for anything else, this shouldn't be an issue, and this is also considered best-practice. We could also look into moving the methods within these files into their own file(s), for example utils.py.

@mklarz mklarz added the enhancement New feature or request label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant