[macos] adding support for message bridge #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
shakyShane
force-pushed
the
11-15-adding_support_for_message_bridge
branch
from
098bf44 to
eed566d
Compare
shakyShane
changed the title
10 tasks
shakyShane
force-pushed
the
11-15-adding_support_for_message_bridge
branch
from
6601a6a to
27dd563
Compare
14 tasks
jotaemepereira
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
I tested the steps described in the PR description and everything looks as expected 👍🏼 . Thanks @shakyShane !
shakyShane
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 19, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/0/1208773745506348/f iOS PR: duckduckgo/iOS#3588 macOS PR: duckduckgo/macos-browser#3558 What kind of version bump will this require?: Major/Minor/Patch **Optional**: Tech Design URL: CC: **Description**: <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Steps to test this PR**: 1. See the macOS PR duckduckgo/macos-browser#3558 <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) Co-authored-by: Shane Osbourne <[email protected]>
shakyShane
force-pushed
the
11-15-adding_support_for_message_bridge
branch
from
27dd563 to
fb5ab9b
Compare
samsymons
added a commit
that referenced
this pull request
Nov 21, 2024
…g-error # By Anka (5) and others # Via GitHub (5) and Dominik Kapusta (1) * main: (28 commits) Add attemptCount and maxAttempts to broker config (#3533) Hide continue setup cards after 1 week (#3471) Add expectation when checking email text field value (#3572) [macos] adding support for message bridge (#3558) Update PIR test runner (#3570) Add support for controlling sections visibility on HTML New Tab Page (#3551) Bump version to 1.115.0 (311) macOS 13/14 UI test compilation fix (#3569) macOS 13/14 UI test compilation fix (#3569) Fix bug where bookmarks bar prompt does not hide bar (#3553) Add OS version to download fail pixel (#3568) Remove get_tasks_in_last_internal_release (#3566) Bump version to 1.115.0 (310) Update skip-release check Update fastlane plugin to 0.11.6 Bump ddg-apple-automation version for bugfix (#3565) PIR E2E tests GitHub actions (#3528) Update autoconsent to v11.5.0 (#3561) Bump version to 1.115.0 (309) Set marketing version to 1.115.0 ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208773745506350/f
Tech Design URL:
CC:
Description:
See the Asana task for more details - but a short version is that a recent change in C-S-S requires another UUID - I deliberately DO NOT want to re-use
sessionKey, since that's used in other places already and it would be unclear when/where we could change this.messageSecretwas chosen to match what android already useSteps to test this PR: (👀 VIDEO below)
https://bridge-example.netlify.app/ai-chat.htmlhttps://bridge-example.netlify.app/ai-chat.jsonAI Chat -> Web Communication -> Set Custom URL
ai-chat.mp4
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation
Definition of Done:Definition of Done:
Internal references:###### Internal references:
Pull Request Review ChecklistPull Request Review Checklist
Software Engineering ExpectationsSoftware Engineering Expectations
Technical Design TemplateTechnical Design Template
Pull Request DocumentationPull Request Documentation