Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Untitled tab title #2650

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Add Untitled tab title #2650

merged 4 commits into from
Apr 23, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204912272578138/1206900493125406/f

Description:

  • Add "Untitled" title for empty tab

Steps to test this PR:

  1. Open hexfiend.com, cmd+click the Download button,
  2. wait until the download tab loads
  3. Validate "Untitled" title

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from tomasstrba April 19, 2024 13:08
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is my favourite! 👍 LGTM! ✅

@mallexxx mallexxx marked this pull request as ready for review April 23, 2024 14:39
@mallexxx mallexxx changed the title [WIP] Add Untitled tab title Add Untitled tab title Apr 23, 2024
@mallexxx mallexxx merged commit ac42cb8 into main Apr 23, 2024
20 checks passed
@mallexxx mallexxx deleted the alex/untitled-tab branch April 23, 2024 14:48
samsymons added a commit that referenced this pull request Apr 24, 2024
* main: (22 commits)
  Fix DataBrokerProtectionProcessor.swift lint
  Fix SwiftLint
  Add parameter allowed encoding to error descriptions (#2691)
  Remove debug flags
  Bump version to 1.85.0 (174)
  Revert interrupt logic (#2699)
  Fix downloads not appearing (#2693)
  Bump version to 1.85.0 (173)
  DBP interrupt fixes for release  (#2696)
  Bookmark All Tabs (#2683)
  Fix DBP interrupt function not being cleared on succesful completion (#2690)
  Bump version to 1.85.0 (172)
  Validate DBP permissions (#2673)
  Bump BSK (#2688)
  Add Untitled tab title (#2650)
  Stop first scan completed notification being sent if there's an error (#2685)
  DBP: Rename scanAllBrokers to startManualScan (#2679)
  macOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2652)
  Bump version to 1.85.0 (171)
  [Release PR] Link Lottie with the NetworkProtectionUI library (#2676)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants