From 3b896a9b9824edcaa310f4e26fdd1d0768d2c5d4 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Mon, 18 Dec 2023 17:22:19 +0100 Subject: [PATCH 01/17] add test can remove data --- SyncE2EUITests/CriticalPathsTests.swift | 40 +++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/SyncE2EUITests/CriticalPathsTests.swift b/SyncE2EUITests/CriticalPathsTests.swift index 6d08567abe..949dba9b94 100644 --- a/SyncE2EUITests/CriticalPathsTests.swift +++ b/SyncE2EUITests/CriticalPathsTests.swift @@ -107,6 +107,46 @@ final class CriticalPathsTests: XCTestCase { XCTAssertTrue(beginSync.exists, "Begyn Sync text is not visible") } + func testCanRemoveData() { + // Go to Sync Set up + let newTabWindow = app.windows["New Tab"] + newTabWindow.children(matching: .button).element(boundBy: 4).click() + newTabWindow.menuItems["openPreferences:"].click() + let settingsWindow = app.windows["Settings"] + settingsWindow.buttons["Sync & Backup"].click() + + // Create Account + let sheetsQuery = settingsWindow.sheets + settingsWindow.staticTexts["Sync and Back Up This Device"].click() + sheetsQuery.buttons["Turn on Sync & Backup"].click() + sheetsQuery.buttons["Copy Code"].click() + sheetsQuery.buttons["Next"].click() + sheetsQuery.buttons["Done"].click() + let syncEnabledElement = settingsWindow.staticTexts["Sync Enabled"] + XCTAssertTrue(syncEnabledElement.exists, "Sync Enabled text is not visible") + + // Delete Data + settingsWindow.swipeUp() + settingsWindow.buttons["Turn Off and Delete Server Data"].click() + sheetsQuery.buttons["Delete Data"].click() + let beginSync = settingsWindow.staticTexts["Begin Syncing"] + beginSync.click() + XCTAssertTrue(beginSync.exists, "Begyn Sync text is not visible") + + // Log In and check error + settingsWindow.staticTexts["Sync with Another Device"].click() + let settingsSheetsQuery = settingsWindow.sheets + settingsSheetsQuery.staticTexts["Enter Code"].click() + settingsSheetsQuery.buttons["Paste"].click() + let alertSheet = sheetsQuery.sheets["alert"] + alertSheet.staticTexts["Sync Error"].click() + XCTAssertTrue(alertSheet.exists, "Sync Error text is not visible") + + // Clean Up + debugMenuBarItem.click() + internaluserstateMenuItem.click() + } + func testCanLoginToExistingSyncAccount() { guard let code = ProcessInfo.processInfo.environment["CODE"] else { XCTFail("CODE not set") From e37a54fa3f7afdd5d4871e702e8152f309324307 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 13:59:40 +0100 Subject: [PATCH 02/17] create CI workflow --- .github/workflows/Sync-End-to-End tests.yml | 127 ++++++++++++++++++++ 1 file changed, 127 insertions(+) create mode 100644 .github/workflows/Sync-End-to-End tests.yml diff --git a/.github/workflows/Sync-End-to-End tests.yml b/.github/workflows/Sync-End-to-End tests.yml new file mode 100644 index 0000000000..cc84ebfa6d --- /dev/null +++ b/.github/workflows/Sync-End-to-End tests.yml @@ -0,0 +1,127 @@ +name: Sync-End-to-End tests + +on: + workflow_dispatch: + push: + schedule: + - cron: '0 5 * * *' # run at 5 AM UTC + +jobs: + sync-end-to-end-tests: + name: Sync End to end Tests + runs-on: macos-13-xlarge + + steps: + - name: Check out the code + uses: actions/checkout@v3 + with: + submodules: recursive + + - name: Set cache key hash + run: | + has_only_tags=$(jq '[ .pins[].state | has("version") ] | all' DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved) + if [[ "$has_only_tags" == "true" ]]; then + echo "cache_key_hash=${{ hashFiles('DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved') }}" >> $GITHUB_ENV + else + echo "Package.resolved contains dependencies specified by branch or commit, skipping cache." + fi + + - name: Cache SPM + if: env.cache_key_hash + uses: actions/cache@v3 + with: + path: DerivedData/SourcePackages + key: ${{ runner.os }}-spm-${{ env.cache_key_hash }} + restore-keys: | + ${{ runner.os }}-spm- + + - name: Select Xcode + run: sudo xcode-select -s /Applications/Xcode_$(<.xcode-version).app/Contents/Developer + + - name: Install xcbeautify + continue-on-error: true + run: | + if ! command -v xcbeautify &> /dev/null; then + brew install xcbeautify + fi + + - name: Create test account for Sync and return the recovery code + uses: duckduckgo/sync_crypto/action@main + id: sync-recovery-code + with: + debug: true + + - name: Build and run Sync e2e test 1 + run: | + set -o pipefail && xcodebuild test \ + -scheme "Sync End-to-End UI Tests" \ + -configuration "CI" \ + -derivedDataPath "DerivedData" \ + -only-testing:CriticalPathsTests/testCanCreateSyncAccount \ + | tee xcodebuild.log \ + | xcbeautify + + - name: Run clean-app.sh review + run: | + ./clean-app.sh review + + - name: Build and run Sync e2e test 2 + run: | + set -o pipefail && xcodebuild test \ + -scheme "Sync End-to-End UI Tests" \ + -configuration "CI" \ + -derivedDataPath "DerivedData" \ + -only-testing:CriticalPathsTests/testCanRecoverSyncAccount \ + | tee xcodebuild.log \ + | xcbeautify + + - name: Run clean-app.sh review + run: | + ./clean-app.sh review + + - name: Build and run Sync e2e test 3 + env: + CODE: ${{ steps.sync-recovery-code.outputs.recovery-code }} + run: | + set -o pipefail && xcodebuild test \ + -scheme "Sync End-to-End UI Tests" \ + -configuration "CI" \ + -derivedDataPath "DerivedData" \ + -only-testing:CriticalPathsTests/testCanLoginToExistingSyncAccount \ + | tee xcodebuild.log \ + | xcbeautify + + - name: Run clean-app.sh review + run: | + ./clean-app.sh review + + - name: Build and run Sync e2e test 4 + env: + CODE: ${{ steps.sync-recovery-code.outputs.recovery-code }} + run: | + set -o pipefail && xcodebuild test \ + -scheme "Sync End-to-End UI Tests" \ + -configuration "CI" \ + -derivedDataPath "DerivedData" \ + -only-testing:CriticalPathsTests/testCanSyncData \ + | tee xcodebuild.log \ + | xcbeautify + + - name: Create Asana task when workflow failed + if: ${{ failure() }} + run: | + curl -s "https://app.asana.com/api/1.0/tasks" \ + --header "Accept: application/json" \ + --header "Authorization: Bearer ${{ secrets.ASANA_ACCESS_TOKEN }}" \ + --header "Content-Type: application/json" \ + --data ' { "data": { "name": "GH Workflow Failure - Sync End to end tests", "projects": [ "${{ vars.MACOS_APP_DEVELOPMENT_ASANA_PROJECT_ID }}" ], "notes" : "The end to end workflow has failed. See https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" } }' + + - name: Upload logs when workflow failed + uses: actions/upload-artifact@v3 + if: failure() + with: + name: BuildLogs + path: | + xcodebuild.log + DerivedData/Logs/Test/*.xcresult + retention-days: 7 From b0f0e855b32a207894911dabee00991f01838d13 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:06:58 +0100 Subject: [PATCH 03/17] update --- .../{Sync-End-to-End tests.yml => Sync-End-to-End-tests.yml} | 2 ++ 1 file changed, 2 insertions(+) rename .github/workflows/{Sync-End-to-End tests.yml => Sync-End-to-End-tests.yml} (99%) diff --git a/.github/workflows/Sync-End-to-End tests.yml b/.github/workflows/Sync-End-to-End-tests.yml similarity index 99% rename from .github/workflows/Sync-End-to-End tests.yml rename to .github/workflows/Sync-End-to-End-tests.yml index cc84ebfa6d..a656884337 100644 --- a/.github/workflows/Sync-End-to-End tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -3,6 +3,8 @@ name: Sync-End-to-End tests on: workflow_dispatch: push: + branches: + - sabrina/sync_e2e_ci schedule: - cron: '0 5 * * *' # run at 5 AM UTC From 56c24d6b2d337e135366427f0e7cc99706c0ea34 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:09:02 +0100 Subject: [PATCH 04/17] update --- .github/workflows/Sync-End-to-End-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index a656884337..eec0bf4fec 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -3,7 +3,7 @@ name: Sync-End-to-End tests on: workflow_dispatch: push: - branches: + branches: - sabrina/sync_e2e_ci schedule: - cron: '0 5 * * *' # run at 5 AM UTC From 77b5422eab436463558df99cbc20935dcc108afe Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:11:45 +0100 Subject: [PATCH 05/17] update --- .github/workflows/Sync-End-to-End-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index eec0bf4fec..818d7a952d 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -1,4 +1,4 @@ -name: Sync-End-to-End tests +name: sync-end-to-end-tests on: workflow_dispatch: From 8762a9f24fadca24f4b772ee5be88d00dbcedd59 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:13:38 +0100 Subject: [PATCH 06/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index 818d7a952d..4d167776c0 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -1,10 +1,10 @@ name: sync-end-to-end-tests on: - workflow_dispatch: push: branches: - sabrina/sync_e2e_ci + pull_request: schedule: - cron: '0 5 * * *' # run at 5 AM UTC From 98be528fcbb434482987d69a05075c7e018b4e5f Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:16:06 +0100 Subject: [PATCH 07/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index 4d167776c0..e450a7b079 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -9,7 +9,7 @@ on: - cron: '0 5 * * *' # run at 5 AM UTC jobs: - sync-end-to-end-tests: + e2e: name: Sync End to end Tests runs-on: macos-13-xlarge From 7234c54ddb711b01768e36c78e3f61ca8f0ca155 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:21:46 +0100 Subject: [PATCH 08/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index e450a7b079..3618d566d2 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -5,11 +5,13 @@ on: branches: - sabrina/sync_e2e_ci pull_request: - schedule: - - cron: '0 5 * * *' # run at 5 AM UTC + branches: + - sabrina/sync_e2e_ci + # schedule: + # - cron: '0 5 * * *' # run at 5 AM UTC jobs: - e2e: + sync-e2e-tests: name: Sync End to end Tests runs-on: macos-13-xlarge From 9965fc52f02a7234d1fd0e85d8638a5cd0ba1f3e Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:23:36 +0100 Subject: [PATCH 09/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 22 +++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index 3618d566d2..08a613b531 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -1,19 +1,21 @@ name: sync-end-to-end-tests -on: +on: push: - branches: - - sabrina/sync_e2e_ci + branches: [ main, "release/**" ] pull_request: - branches: - - sabrina/sync_e2e_ci - # schedule: - # - cron: '0 5 * * *' # run at 5 AM UTC + workflow_call: + inputs: + branch: + description: "Branch name" + required: false + type: string + secrets: + ASANA_ACCESS_TOKEN: + required: true jobs: - sync-e2e-tests: - name: Sync End to end Tests - runs-on: macos-13-xlarge + test: steps: - name: Check out the code From 5e6dece27befe64105b441f22f520074cc9a4c2a Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:24:59 +0100 Subject: [PATCH 10/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index 08a613b531..dd36ef9408 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -16,7 +16,6 @@ on: jobs: test: - steps: - name: Check out the code uses: actions/checkout@v3 From 491e8e38de9577b089c7bbbc6aae812feba79897 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:26:44 +0100 Subject: [PATCH 11/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index dd36ef9408..ac6cde643a 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -112,14 +112,14 @@ jobs: | tee xcodebuild.log \ | xcbeautify - - name: Create Asana task when workflow failed - if: ${{ failure() }} - run: | - curl -s "https://app.asana.com/api/1.0/tasks" \ - --header "Accept: application/json" \ - --header "Authorization: Bearer ${{ secrets.ASANA_ACCESS_TOKEN }}" \ - --header "Content-Type: application/json" \ - --data ' { "data": { "name": "GH Workflow Failure - Sync End to end tests", "projects": [ "${{ vars.MACOS_APP_DEVELOPMENT_ASANA_PROJECT_ID }}" ], "notes" : "The end to end workflow has failed. See https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" } }' + # - name: Create Asana task when workflow failed + # if: ${{ failure() }} + # run: | + # curl -s "https://app.asana.com/api/1.0/tasks" \ + # --header "Accept: application/json" \ + # --header "Authorization: Bearer ${{ secrets.ASANA_ACCESS_TOKEN }}" \ + # --header "Content-Type: application/json" \ + # --data ' { "data": { "name": "GH Workflow Failure - Sync End to end tests", "projects": [ "${{ vars.MACOS_APP_DEVELOPMENT_ASANA_PROJECT_ID }}" ], "notes" : "The end to end workflow has failed. See https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" } }' - name: Upload logs when workflow failed uses: actions/upload-artifact@v3 From e0ab06254abd217bd819c9d223ca86396bafc495 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:29:26 +0100 Subject: [PATCH 12/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index ac6cde643a..6bdde440fd 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -112,21 +112,4 @@ jobs: | tee xcodebuild.log \ | xcbeautify - # - name: Create Asana task when workflow failed - # if: ${{ failure() }} - # run: | - # curl -s "https://app.asana.com/api/1.0/tasks" \ - # --header "Accept: application/json" \ - # --header "Authorization: Bearer ${{ secrets.ASANA_ACCESS_TOKEN }}" \ - # --header "Content-Type: application/json" \ - # --data ' { "data": { "name": "GH Workflow Failure - Sync End to end tests", "projects": [ "${{ vars.MACOS_APP_DEVELOPMENT_ASANA_PROJECT_ID }}" ], "notes" : "The end to end workflow has failed. See https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" } }' - - - name: Upload logs when workflow failed - uses: actions/upload-artifact@v3 - if: failure() - with: - name: BuildLogs - path: | - xcodebuild.log - DerivedData/Logs/Test/*.xcresult - retention-days: 7 + From 5627fefcabe397e17bafbbe089a0030488bd1c49 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Tue, 19 Dec 2023 14:31:38 +0100 Subject: [PATCH 13/17] again --- .github/workflows/Sync-End-to-End-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index 6bdde440fd..1bb2a92f99 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -16,6 +16,7 @@ on: jobs: test: + runs-on: macos-13-xlarge steps: - name: Check out the code uses: actions/checkout@v3 From 0f2ef3b408d5a65f8993071ac78fcd456f65acd1 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Wed, 20 Dec 2023 14:33:54 +0100 Subject: [PATCH 14/17] test --- .github/workflows/Sync-End-to-End-tests.yml | 91 ++++++++++----------- 1 file changed, 45 insertions(+), 46 deletions(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index 1bb2a92f99..5e5c04660c 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -63,54 +63,53 @@ jobs: -scheme "Sync End-to-End UI Tests" \ -configuration "CI" \ -derivedDataPath "DerivedData" \ - -only-testing:CriticalPathsTests/testCanCreateSyncAccount \ | tee xcodebuild.log \ | xcbeautify - - name: Run clean-app.sh review - run: | - ./clean-app.sh review - - - name: Build and run Sync e2e test 2 - run: | - set -o pipefail && xcodebuild test \ - -scheme "Sync End-to-End UI Tests" \ - -configuration "CI" \ - -derivedDataPath "DerivedData" \ - -only-testing:CriticalPathsTests/testCanRecoverSyncAccount \ - | tee xcodebuild.log \ - | xcbeautify - - - name: Run clean-app.sh review - run: | - ./clean-app.sh review - - - name: Build and run Sync e2e test 3 - env: - CODE: ${{ steps.sync-recovery-code.outputs.recovery-code }} - run: | - set -o pipefail && xcodebuild test \ - -scheme "Sync End-to-End UI Tests" \ - -configuration "CI" \ - -derivedDataPath "DerivedData" \ - -only-testing:CriticalPathsTests/testCanLoginToExistingSyncAccount \ - | tee xcodebuild.log \ - | xcbeautify - - - name: Run clean-app.sh review - run: | - ./clean-app.sh review - - - name: Build and run Sync e2e test 4 - env: - CODE: ${{ steps.sync-recovery-code.outputs.recovery-code }} - run: | - set -o pipefail && xcodebuild test \ - -scheme "Sync End-to-End UI Tests" \ - -configuration "CI" \ - -derivedDataPath "DerivedData" \ - -only-testing:CriticalPathsTests/testCanSyncData \ - | tee xcodebuild.log \ - | xcbeautify +# - name: Run clean-app.sh review +# run: | +# ./clean-app.sh review +# +# - name: Build and run Sync e2e test 2 +# run: | +# set -o pipefail && xcodebuild test \ +# -scheme "Sync End-to-End UI Tests" \ +# -configuration "CI" \ +# -derivedDataPath "DerivedData" \ +# -only-testing:CriticalPathsTests/testCanRecoverSyncAccount \ +# | tee xcodebuild.log \ +# | xcbeautify +# +# - name: Run clean-app.sh review +# run: | +# ./clean-app.sh review +# +# - name: Build and run Sync e2e test 3 +# env: +# CODE: ${{ steps.sync-recovery-code.outputs.recovery-code }} +# run: | +# set -o pipefail && xcodebuild test \ +# -scheme "Sync End-to-End UI Tests" \ +# -configuration "CI" \ +# -derivedDataPath "DerivedData" \ +# -only-testing:CriticalPathsTests/testCanLoginToExistingSyncAccount \ +# | tee xcodebuild.log \ +# | xcbeautify +# +# - name: Run clean-app.sh review +# run: | +# ./clean-app.sh review +# +# - name: Build and run Sync e2e test 4 +# env: +# CODE: ${{ steps.sync-recovery-code.outputs.recovery-code }} +# run: | +# set -o pipefail && xcodebuild test \ +# -scheme "Sync End-to-End UI Tests" \ +# -configuration "CI" \ +# -derivedDataPath "DerivedData" \ +# -only-testing:CriticalPathsTests/testCanSyncData \ +# | tee xcodebuild.log \ +# | xcbeautify From 543d5d4dd528519ef8156c0af11f1e3adae44156 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Wed, 20 Dec 2023 14:38:13 +0100 Subject: [PATCH 15/17] test --- .github/workflows/Sync-End-to-End-tests.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index 5e5c04660c..de73dc46f2 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -15,6 +15,19 @@ on: required: true jobs: + + swiftlint: + + name: SwiftLint + + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + - name: SwiftLint + uses: docker://norionomura/swiftlint:0.54.0 + with: + args: swiftlint --reporter github-actions-logging --strict test: runs-on: macos-13-xlarge steps: From 03c34ef5464ac8962d4413cdf1c31f29151fa5f5 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Wed, 20 Dec 2023 15:07:10 +0100 Subject: [PATCH 16/17] test --- .github/workflows/Sync-End-to-End-tests.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index de73dc46f2..b984ad10fc 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -16,18 +16,7 @@ on: jobs: - swiftlint: - name: SwiftLint - - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v3 - - name: SwiftLint - uses: docker://norionomura/swiftlint:0.54.0 - with: - args: swiftlint --reporter github-actions-logging --strict test: runs-on: macos-13-xlarge steps: From 875575ce7a9520c7404f4adc19e908e6eeece029 Mon Sep 17 00:00:00 2001 From: Sabrina Tardio Date: Wed, 20 Dec 2023 15:11:11 +0100 Subject: [PATCH 17/17] test --- .github/workflows/Sync-End-to-End-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Sync-End-to-End-tests.yml b/.github/workflows/Sync-End-to-End-tests.yml index b984ad10fc..2a86383804 100644 --- a/.github/workflows/Sync-End-to-End-tests.yml +++ b/.github/workflows/Sync-End-to-End-tests.yml @@ -65,6 +65,7 @@ jobs: -scheme "Sync End-to-End UI Tests" \ -configuration "CI" \ -derivedDataPath "DerivedData" \ + -skipPackagePluginValidation \ | tee xcodebuild.log \ | xcbeautify