From c712413b088d3636925beac70cf58c13f4f0f86b Mon Sep 17 00:00:00 2001
From: Diego Rey Mendez <diegoreymendez@users.noreply.github.com>
Date: Fri, 21 Jun 2024 14:41:51 +0200
Subject: [PATCH] Fix VPN toggle failures (#2892)

Task/Issue URL:
https://app.asana.com/0/1207603085593419/1207629954356116/f

iOS PR: https://github.com/duckduckgo/iOS/pull/2979
BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/858

## Description

The VPN toggle is sometimes failing silently, apparently due to a race
condition created by calls to `sendProviderMessage` while the VPN is
starting up.

This PR changes our logic to limit when those calls are made, since none
of them make sense to call when the VPN is connecting.
---
 DuckDuckGo.xcodeproj/project.pbxproj                          | 2 +-
 .../project.xcworkspace/xcshareddata/swiftpm/Package.resolved | 4 ++--
 LocalPackages/DataBrokerProtection/Package.swift              | 2 +-
 LocalPackages/NetworkProtectionMac/Package.swift              | 2 +-
 LocalPackages/SubscriptionUI/Package.swift                    | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj
index 35471154b9..e773649d17 100644
--- a/DuckDuckGo.xcodeproj/project.pbxproj
+++ b/DuckDuckGo.xcodeproj/project.pbxproj
@@ -13022,7 +13022,7 @@
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = "156.0.0-1";
+				version = "156.0.0-2";
 			};
 		};
 		9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
index 777467bad5..5b7190b616 100644
--- a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
+++ b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -32,8 +32,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/duckduckgo/BrowserServicesKit",
       "state" : {
-        "revision" : "5362ffc520cbd2579b02c5a9fbdf808e5d75ae95",
-        "version" : "156.0.0-1"
+        "revision" : "2806adf8cae5bffebf0cf5043210f29bac0bade1",
+        "version" : "156.0.0-2"
       }
     },
     {
diff --git a/LocalPackages/DataBrokerProtection/Package.swift b/LocalPackages/DataBrokerProtection/Package.swift
index 54a1a03640..2521d51747 100644
--- a/LocalPackages/DataBrokerProtection/Package.swift
+++ b/LocalPackages/DataBrokerProtection/Package.swift
@@ -29,7 +29,7 @@ let package = Package(
             targets: ["DataBrokerProtection"])
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-2"),
         .package(path: "../SwiftUIExtensions"),
         .package(path: "../XPCHelper"),
     ],
diff --git a/LocalPackages/NetworkProtectionMac/Package.swift b/LocalPackages/NetworkProtectionMac/Package.swift
index 3b0320c4c6..834716184b 100644
--- a/LocalPackages/NetworkProtectionMac/Package.swift
+++ b/LocalPackages/NetworkProtectionMac/Package.swift
@@ -32,7 +32,7 @@ let package = Package(
         .library(name: "VPNAppLauncher", targets: ["VPNAppLauncher"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-2"),
         .package(url: "https://github.com/airbnb/lottie-spm", exact: "4.4.1"),
         .package(path: "../AppLauncher"),
         .package(path: "../UDSHelper"),
diff --git a/LocalPackages/SubscriptionUI/Package.swift b/LocalPackages/SubscriptionUI/Package.swift
index 562e336bb6..466259fecd 100644
--- a/LocalPackages/SubscriptionUI/Package.swift
+++ b/LocalPackages/SubscriptionUI/Package.swift
@@ -12,7 +12,7 @@ let package = Package(
             targets: ["SubscriptionUI"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-2"),
         .package(path: "../SwiftUIExtensions")
     ],
     targets: [