From 04fa41c10352799edf6048c9fc8cef53074f6bfc Mon Sep 17 00:00:00 2001 From: Dominik Kapusta Date: Tue, 26 Nov 2024 10:26:59 +0100 Subject: [PATCH 1/3] Stop assigning users to NTP Search Box Experiment cohorts (#3597) Task/Issue URL: https://app.asana.com/0/72649045549333/1208746673107049/f Description: This change stops assigning new users to experiment, while keeping Search Box visible for users that have previously been enrolled. --- DuckDuckGo/HomePage/Model/HomePageAddressBarModel.swift | 1 - 1 file changed, 1 deletion(-) diff --git a/DuckDuckGo/HomePage/Model/HomePageAddressBarModel.swift b/DuckDuckGo/HomePage/Model/HomePageAddressBarModel.swift index 12b321117a..9d5f2ed60d 100644 --- a/DuckDuckGo/HomePage/Model/HomePageAddressBarModel.swift +++ b/DuckDuckGo/HomePage/Model/HomePageAddressBarModel.swift @@ -101,7 +101,6 @@ extension HomePage.Models { func setUpExperimentIfNeeded() { if isExperimentActive { let ntpExperiment = NewTabPageSearchBoxExperiment() - ntpExperiment.assignUserToCohort() shouldShowAddressBar = ntpExperiment.cohort?.isExperiment == true } } From 12e5529f0e110d65314904d73c81595bd22fb1ab Mon Sep 17 00:00:00 2001 From: Dominik Kapusta Date: Tue, 26 Nov 2024 20:51:48 +0100 Subject: [PATCH 2/3] Only fire Duck Player navigational pixel for main frame navigations (#3599) Task/Issue URL: https://app.asana.com/0/1203249713006009/1208836976436118/f Description: This change limits Duck Player navigational pixels to be sent only on main frame navigations --- DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift b/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift index a05d0e03ba..0fc03ac3f5 100644 --- a/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift +++ b/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift @@ -246,7 +246,7 @@ extension DuckPlayerTabExtension: NavigationResponder { } // Fire DuckPlayer temporary pixels on navigating outside Youtube - if let url = navigationAction.request.url, !url.isYoutube { + if let url = navigationAction.request.url, !url.isYoutube, navigationAction.isForMainFrame { duckPlayerOverlayUsagePixels.handleNavigationAndFirePixels(url: url, duckPlayerMode: duckPlayer.mode) } From b544d195c0f6c5815be89712f8aa108aa6ac565c Mon Sep 17 00:00:00 2001 From: Anka Date: Wed, 27 Nov 2024 05:17:32 +0000 Subject: [PATCH 3/3] Bump version to 1.116.0 (316) --- Configuration/BuildNumber.xcconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Configuration/BuildNumber.xcconfig b/Configuration/BuildNumber.xcconfig index b67126ba15..cdfc01dfbb 100644 --- a/Configuration/BuildNumber.xcconfig +++ b/Configuration/BuildNumber.xcconfig @@ -1 +1 @@ -CURRENT_PROJECT_VERSION = 315 +CURRENT_PROJECT_VERSION = 316