From 948f8b417079cc08c19f0c1b740f80b8ca8e3bbb Mon Sep 17 00:00:00 2001 From: Pete Smith Date: Mon, 24 Jun 2024 17:42:22 +0200 Subject: [PATCH] Add Definition of Done to PR template (#2898) Task/Issue URL: https://app.asana.com/0/1200194497630846/1207586679915793/f Tech Design URL: CC: **Description**: Add our Apple Team Definition of Done to the PR template --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f88261e219..2e8f1ef2c4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,6 +15,10 @@ If it's pending Product Review/PFR, please add the `Pending Product Review` labe If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> +**Definition of Done**: + +* [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? + --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)