Fix showing bars on tapping bottom of the screen #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
commented
Dec 5, 2024
| @@ -1007,7 +1007,7 @@ class TabViewController: UIViewController { | |||
| } | |||
|
|
|||
| @IBAction func onBottomOfScreenTapped(_ sender: UITapGestureRecognizer) { | |||
| showBars(animated: false) | |||
| showBars() | |||
There was a problem hiding this comment.
Not sure if this was on purpose, but tested with animation (the same as when tapping area on top) and it worked.
brindy
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208832461871070/f
Tech Design URL:
CC:
Description:
Updated the way how "bottom of screen" is calculated. I think this was broken for some time already but nobody noticed.
Changed to show the bars with animation.
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template