From 230a3d1864900b3240969f1805cc5a9c83b233db Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mariusz=20=C5=9Apiewak?= <dus7@users.noreply.github.com>
Date: Tue, 26 Nov 2024 18:32:33 +0100
Subject: [PATCH] Prevent showing favorites suggestion tray when opening
 DuckPlayer (#3622)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Task/Issue URL:
https://app.asana.com/0/1203249713006009/1208838384448084/f
Tech Design URL:
CC:

**Description**:

When opening DuckPlayer in New Tab, we're going through multiple states
of OmniBar, one of which is attempting to clear the URL field. This is
causing the controller to show up. However it should not appear, since
the URL Text Field is not being edited.

⚠️ I wasn't able to reproduce this on Simulator 100%. Had more luck on a
device.

**Steps to test this PR**:
1. Add at least one Favorite.
1. Search for YouTube video in the SERP (e.g. "youtube duck").
2. Make sure DuckPlayer is set to "ask every time".
3. When prompted open video in DuckPlayer.
4. DP should open in new tab (if the setting is enabled), favorites
should not.

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Device Testing**:

* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
---
 DuckDuckGo/MainViewController.swift | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DuckDuckGo/MainViewController.swift b/DuckDuckGo/MainViewController.swift
index 2105b1c6c5..29ed297fec 100644
--- a/DuckDuckGo/MainViewController.swift
+++ b/DuckDuckGo/MainViewController.swift
@@ -1825,7 +1825,7 @@ extension MainViewController: OmniBarDelegate {
 
     func onOmniQueryUpdated(_ updatedQuery: String) {
         if updatedQuery.isEmpty {
-            if newTabPageViewController != nil {
+            if newTabPageViewController != nil || !omniBar.textField.isEditing {
                 hideSuggestionTray()
             } else {
                 let didShow = tryToShowSuggestionTray(.favorites)