Skip to content
This repository has been archived by the owner on Jan 10, 2019. It is now read-only.

CODIO: protect against terrible module names #147

Open
zekiel opened this issue Nov 11, 2014 · 3 comments
Open

CODIO: protect against terrible module names #147

zekiel opened this issue Nov 11, 2014 · 3 comments
Labels
Bug

Comments

@zekiel
Copy link
Member

zekiel commented Nov 11, 2014

After clicking the DuckPAN New Goodie tab in Codio (step 1 here, pressing enter creates a new goodie named:

e.g. after clicking "cd ~/workspace/zeroclickinfo-goodies && duckpan new
@zekiel
Copy link
Member Author

zekiel commented Nov 11, 2014

can't reproduce.

@zekiel zekiel closed this as completed Nov 11, 2014
@zekiel zekiel reopened this Nov 11, 2014
@zekiel
Copy link
Member Author

zekiel commented Nov 11, 2014

screen shot 2014-11-10 at 11 10 42 pm

should pop a confirmation against bad file naming per @moollaza suggestion

@moollaza moollaza added the Bug label Nov 11, 2014
@moollaza
Copy link
Member

There's definitely a safe-guard against the user just pressing "Enter" at the prompt, but we don't really check if the input is just a bunch of spaces or " ".

Working on a PR to fix this.

@zekiel zekiel changed the title CODIO: Pressing Enter w/ no name creates a quick-start goodie named *directory CODIO: protect against terrible module names Nov 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moollaza @zekiel