Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that the METplus differences logic handles MTD output file #977

Open
21 tasks
dwfncar opened this issue Mar 19, 2018 · 1 comment
Open
21 tasks

Confirm that the METplus differences logic handles MTD output file #977

dwfncar opened this issue Mar 19, 2018 · 1 comment
Assignees
Labels
component: testing Software testing issue priority: high High Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone

Comments

@dwfncar
Copy link
Contributor

dwfncar commented Mar 19, 2018

Describe the Task

The testing infrastructure for MET does not do a good job checking for differences in MTD output files. It first calls diff, and if there are no differences, everything is fine. If there are differences, you see this type of error:

COMPARING mtd/mtd_BASIC_20100517_010000V_2d.txt
file1: test_output_rev5319/mtd/mtd_BASIC_20100517_010000V_2d.txt
file2: test_output_rev5351/mtd/mtd_BASIC_20100517_010000V_2d.txt
cat: /d3/projects/MET/MET_regression/NB20180319/test_rev5351/hdr/met_NA.hdr: No such file or directory
Error in strsplit(strHdr, " ") : non-character argument

In addition: There were 50 or more warnings (use warnings() to see the first 50)

ERROR: compareStat() failed

This task is to update the testing infrastructure to handle the MTD output.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@dwfncar dwfncar added the component: testing Software testing issue label Apr 30, 2019
@dwfncar dwfncar added this to the MET 9.0 milestone Apr 30, 2019
@JohnHalleyGotway JohnHalleyGotway added priority: high alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle requestor: METplus Team METplus Development Team labels Apr 19, 2022
@JohnHalleyGotway JohnHalleyGotway added priority: high High Priority and removed priority: high labels May 9, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from 📖 Backlog to 🟢 Ready in MET-12.1.0 Development Oct 3, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Update the MET testing infrastructure to check for differences in MTD output files. Confirm that the METplus differences logic handles MTD output file Nov 5, 2024
@JohnHalleyGotway
Copy link
Collaborator

Note that #2718 switches from internal MET differencing logic to using METplus instead. Confirm that differencing of MTD outputs are well-supported there.

@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Nov 5, 2024
@JohnHalleyGotway JohnHalleyGotway added type: task An actionable item of work and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: testing Software testing issue priority: high High Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
Status: 🟢 Ready
Development

No branches or pull requests

3 participants