-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GRIB tables in MET based on wgrib2 versions 3.1.4 and 3.4.0 #2780
Comments
Note that discussion dtcenter/METplus#2465 points out that the On 10/31/2024, confirmed that
|
At the METplus NOAA User Telecon on 5/13/24, @MarcelCaron-NOAA requested that Test to confirm that the ice product data is read from these files well. |
For this issue, recommend updating additional static data sources:
|
Details about updating the GRIB2 tables:
Ran the following commands to reformat the existing data files to match the current format in MET:
When updating the existing tables, make sure:
Had to carefully merge existing
Made no updates to Wrote up NOAA-EMC/wgrib2#285 to alert them of 2 minor GRIB2 table file issues I encountered. |
…with updates from the 109 defined in the wgrib2 table.
Wesley's source code of wgrib2 v3.1.4 is on
Hera:/home/Wesley.Ebisuzaki/grib2/wgrib2. The GRIB2 tables in this version
have been updated with the NCEP GRIB2 documentation
<https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-1.shtml>.
The /home/Wesley.Ebisuzaki/grib2/wgrib2/gribtables/ncep/gribtable.dat file
contains ALBDOICE and SICEVOL. The
/home/Wesley.Ebisuzaki/grib2/wgrib2/Level.c file has the new mixed layer
depth (Level 172 in Table 4.5
<https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-5.shtml>
).
THE NCEPLIB team may have taken an older version of wgrib2 code and
developed from there. I saw you already opened a wgrib2 issue (#285
<NOAA-EMC/wgrib2#285>) on suspicious GRIB2 table
entries. Please relay this information to them.
Thanks,
Gwen
…On Wed, Oct 30, 2024 at 5:09 PM John Halley Gotway ***@***.***> wrote:
@GwenChen-NOAA <https://github.com/GwenChen-NOAA>, I did update the GRIB2
tables for MET based on the contents of this wgrib2 gribtables
<https://github.com/NOAA-EMC/wgrib2/tree/develop/wgrib2/gribtables>
directory. However, I spot-checked against this GRIB2 table documentation:
https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-10-2.shtml
I was looking for the new WMO-approved variables (27 freezing/melting
potential, 28 melt onset date, and 29 freeze onset date in Table 4.2-10-2
<https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-10-2.shtml>
and Level 172 in Table 4.5
<https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-5.shtml>)...
that are mentioned in the description of this issue.
On line 1122
<https://github.com/NOAA-EMC/wgrib2/blob/cfc151dc94e39eeb44d700ed0ced06316c1d4ce6/wgrib2/gribtables/ncep/gribtable.dat#L1122>
of ncep/gribtable.dat, I see an entry for SNOWTSI... but no entries
following that for ALBDOICE and SICEVOL for example.
So it would appear that the GRIB2 tables in the NOAA-EMC/wgrib2 repo are
NOT up to date with what's published in the GRIB2 documentation. Do you
know of an authoritative source of these tables? Or do I really just need
to scrape content from the website documentation?
—
Reply to this email directly, view it on GitHub
<#2780 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWXF3DEOIKA7CDHY4GL7LYDZ6FDG5AVCNFSM6AAAAABQT2MC4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYGM4DMMJRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I do see ALBDOICE on Line 32
<https://github.com/NOAA-EMC/wgrib2/blob/cfc151dc94e39eeb44d700ed0ced06316c1d4ce6/wgrib2/gribtables/ncep/gribtable.dat#L32>
and SICEVOL on
Line
<https://github.com/NOAA-EMC/wgrib2/blob/cfc151dc94e39eeb44d700ed0ced06316c1d4ce6/wgrib2/gribtables/ncep/gribtable.dat#L1073>
1073
<https://github.com/NOAA-EMC/wgrib2/blob/cfc151dc94e39eeb44d700ed0ced06316c1d4ce6/wgrib2/gribtables/ncep/gribtable.dat#L1073>
of ncep/gribtable.dat
<https://github.com/NOAA-EMC/wgrib2/blob/cfc151dc94e39eeb44d700ed0ced06316c1d4ce6/wgrib2/gribtables/ncep/gribtable.dat>
and
the new mixed layer depth (Level 172 in Table 4.5
<https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-5.shtml>)
on Line 198 of Level.c
<https://github.com/NOAA-EMC/wgrib2/blob/cfc151dc94e39eeb44d700ed0ced06316c1d4ce6/wgrib2/Level.c#L198>.
You may want to double check.
…On Wed, Oct 30, 2024 at 5:51 PM L. Gwen Chen ***@***.***> wrote:
Wesley's source code of wgrib2 v3.1.4 is on
Hera:/home/Wesley.Ebisuzaki/grib2/wgrib2. The GRIB2 tables in this version
have been updated with the NCEP GRIB2 documentation
<https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-1.shtml>.
The /home/Wesley.Ebisuzaki/grib2/wgrib2/gribtables/ncep/gribtable.dat
file contains ALBDOICE and SICEVOL. The
/home/Wesley.Ebisuzaki/grib2/wgrib2/Level.c file has the new mixed layer
depth (Level 172 in Table 4.5
<https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-5.shtml>
).
THE NCEPLIB team may have taken an older version of wgrib2 code and
developed from there. I saw you already opened a wgrib2 issue (#285
<NOAA-EMC/wgrib2#285>) on suspicious GRIB2
table entries. Please relay this information to them.
Thanks,
Gwen
On Wed, Oct 30, 2024 at 5:09 PM John Halley Gotway <
***@***.***> wrote:
> @GwenChen-NOAA <https://github.com/GwenChen-NOAA>, I did update the
> GRIB2 tables for MET based on the contents of this wgrib2 gribtables
> <https://github.com/NOAA-EMC/wgrib2/tree/develop/wgrib2/gribtables>
> directory. However, I spot-checked against this GRIB2 table documentation:
>
> https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-10-2.shtml
>
> I was looking for the new WMO-approved variables (27 freezing/melting
> potential, 28 melt onset date, and 29 freeze onset date in Table 4.2-10-2
> <https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-10-2.shtml>
> and Level 172 in Table 4.5
> <https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-5.shtml>)...
> that are mentioned in the description of this issue.
>
> On line 1122
> <https://github.com/NOAA-EMC/wgrib2/blob/cfc151dc94e39eeb44d700ed0ced06316c1d4ce6/wgrib2/gribtables/ncep/gribtable.dat#L1122>
> of ncep/gribtable.dat, I see an entry for SNOWTSI... but no entries
> following that for ALBDOICE and SICEVOL for example.
>
> So it would appear that the GRIB2 tables in the NOAA-EMC/wgrib2 repo are
> NOT up to date with what's published in the GRIB2 documentation. Do you
> know of an authoritative source of these tables? Or do I really just need
> to scrape content from the website documentation?
>
> —
> Reply to this email directly, view it on GitHub
> <#2780 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWXF3DEOIKA7CDHY4GL7LYDZ6FDG5AVCNFSM6AAAAABQT2MC4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYGM4DMMJRHA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
@GwenChen-NOAA, aha, thanks for pointing out my mistake. I had assumed that they'd be listed in order in the gribtable file, but they are not. I'll keep that in mind and be more careful in my checking. Pulled GRIB tables from
|
@MarcelCaron-NOAA, I can't find a definition for this data. Here's the output from wgrib2:
But no corresponding entry exists in the MRMS GRIB tables:
Can you please advise where the definitions for the FRANA Flat Ice Products can be found? |
@JohnHalleyGotway My understanding is this is a brand new product and I'm not aware of any existing MRMS GRIB table definitions for FRANA ... apart from what I've custom-defined and tested (WCOSS2):
Does that help, or would you need definitions from an operational MRMS GRIB table? |
Details about updating the GRIB1 tables:
Compare these newly generated files with the existing tables and make any changes that are warranted:
Eliminate all embedded whitespace from units string. Also replace all instanced of
Manually edit |
Thanks @MarcelCaron-NOAA! Since those definitions don't conflict with any existing usage, adding them to the |
…ng them more human-readable by replacing ** with ^ to indicate exponentiation. Also correct bad units for radiation flux in AF tables by listing them as W/m^2.
…h 'mcg' to represent micrograms. Also replace 'mm6' with 'mm^6' by double-checking against the GRIB1 docs.
…' for consistent usage across NCEP GRIB tables.
…paring against documentation at https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc
* Per #2780, grib2_bom.txt only has minor change replacing 'Prelim:' with 'Prelim' * Per #2780, grib2_tigge.txt add new table after eliminating whitespace from units strings * Per #2780, grib2_all.txt increase the number of entries from 1019 to 1570. * Per #2780, grib2_kma.txt add new grib2 table file. * Per #2780, carefully merge the existing 175 MRMS GRIB2 table entries with updates from the 109 defined in the wgrib2 table. * Per #2780, grib2_ecmwf.txt add new ECMWF GRIB2 table. * Per #2780, grib2_dwd.txt add new DWD GRIB2 table. * Per #2870, correct units out of order * Per #2870, grib2_gpp_af.txt elimiate embedded whitespace from units string to avoid problems writing them to FCST_UNITS and OBS_UNITS output columns * Per #2780, grib2_ecmwf.txt eliminate whitespace from units string * Per #2780, add/update GRIB2 tables * Per #2870, remove duplicate entries I'd added. * Per #2870, grib2_all.txt update with more entries from this version of wgrib2: hera:/home/Wesley.Ebisuzaki/grib2/wgrib2/gribtables/ncep/gribtable.dat * Per #2780, grib2_mrms.txt add entries for FRANA as requested by @MarcelCaron-NOAA. * Per #2780, add new grib1_jra_55_200.txt file that did not previously exist for MET. * Per #2780, remove embedded whitespace from GRIB1 DWD tables. * Per #2780, fix all the units by removing embedded whitespace and making them more human-readable by replacing ** with ^ to indicate exponentiation. Also correct bad units for radiation flux in AF tables by listing them as W/m^2. * Per #2780 eliminate trailing whitespace * Per #2870, fix typo * Per #2870, fix typos * Per #2870, fix typo * Per #2780, grib1_ncep_129_7.txt fix units by replacing 'µg' with 'mcg' to represent micrograms. Also replace 'mm6' with 'mm^6' by double-checking against the GRIB1 docs. * Per #2780, switch to defining particulate matter units as '10^-6g/m^3' for consistent usage across NCEP GRIB tables. * Per #2780, update GRIB2 units to show exponentiation correctly by comparing against documentation at https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc * Per #2780, more tweaks for consistent and corrected units * Per #2780, update Makefiles for new grib1_jra55_200.txt file * Per #2870, more tweaks for consistent formatting of units to eliminate the use of parantheses in the denominator. For example, replace 'kg/(m*s)' with 'kg/m/s'.
Describe the Enhancement
Note that this work was performed using the GRIB2 table input from:
hera:/home/Wesley.Ebisuzaki/grib2/wgrib2/gribtables
This issue was discussed during the METplus NOAA User Telecon on Jan 8, 2024 (see meeting notes - limited access). Gwen indicated that wgrib2 version 3.1.4 is under development and will include updates to some of the GRIB2 tables. Note that wgrib2 has migrated to GitHub at NOAA-EMC/wgrib2.
This issue is to:
data/table_files/grib2_*.txt
as needed.Recommend requesting that Gwen (Li-Chuan Chen) serve as the tester for these table updates.
Time Estimate
1 day.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: