Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

off-by-one error in yllcenter calculation #218

Open
jcphill opened this issue Sep 26, 2020 · 2 comments
Open

off-by-one error in yllcenter calculation #218

jcphill opened this issue Sep 26, 2020 · 2 comments

Comments

@jcphill
Copy link

jcphill commented Sep 26, 2020

yllcenter=ytopedge-(totalY*dlat)-dlat/2.;

Should be +dlat/2. instead of -dlat/2.

@dtarb
Copy link
Owner

dtarb commented Sep 26, 2020

Thanks. How did you find this and what are its consequences? It seems that a consequence may be that cell size calculations based on latitude may be off by a (very) small amount due to latitude being off by dlat. Are there other consequences you found? I do not think yllcenter is written out. The reason I ask is that I am short handed at the moment so it may be a while till I can fix this

@jcphill
Copy link
Author

jcphill commented Sep 26, 2020

Thanks for the reply. I noticed it while reading the code to investigate an unrelated issue. I haven't observed any consequences, and I can't guess if fixing it would break something else, so no cause to rush anything. Enjoy your weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants