Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs found when testing this resource #17

Open
johlju opened this issue Jan 23, 2017 · 3 comments
Open

Bugs found when testing this resource #17

johlju opened this issue Jan 23, 2017 · 3 comments
Assignees
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Jan 23, 2017

  1. Initiator ID's must be prefixed by IQN:
    https://github.com/PlagueHO/iSCSIDsc/blob/dev/Examples/Sample_iSCSIServerTarget.ps1#L42
    Also the example in the README needs updating (or removed an pointed to the one in Example folder)
InitiatorIds = 'IQN:iqn.2017-01.local.company:cluster01.company.local'
  1. Example for 'iSCSIVirtualDisk iSCSIClusterVDisk02' uses 'UseFixed = $false' which does not exist.
    https://github.com/PlagueHO/iSCSIDsc#examples
    The example in the example folder is correct.
@PlagueHO
Copy link
Member

Awesome catches @johlju - I'll get those fixes in this PR: https://github.com/PlagueHO/iSCSIDsc/pull/16

Although I'm not sure how far away this is from being able to be merged (@kwirkykat ?)

@kwirkykat
Copy link

@PlagueHO Not soon. You can go ahead and add the change.

@PlagueHO
Copy link
Member

Cool! Thanks @kwirkykat 😁

@PlagueHO PlagueHO self-assigned this Aug 8, 2017
@PlagueHO PlagueHO added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

3 participants