Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete alarm: add a button, drop swipe move #268

Open
axelsimon opened this issue Aug 24, 2017 · 9 comments
Open

Delete alarm: add a button, drop swipe move #268

axelsimon opened this issue Aug 24, 2017 · 9 comments
Labels
Milestone

Comments

@axelsimon
Copy link

Hi, I've added a few alarms and now have 6, and they take just slightly more space than can fit on my phone's screen, which means I have to scroll up and down to see them all.

Very often, the alarm under my thumb as I scroll up or down gets deleted, as the slight gesture left or right while going up or down gets registered as a "swipe away" movement to delete the alarm.

Thankfully, it's very easy to undelete an alarm, but the swipe to remove an alarm shouldn't fire so easily I think.

Hope this helps.

@dllud dllud added the bug label Aug 30, 2017
@dllud dllud added this to the 1.0.0 milestone Aug 30, 2017
@dllud
Copy link
Member

dllud commented Aug 30, 2017

Thanks for the report @axelsimon !

This is an old and known bug that should have been documented here before. The problem lies on the X-axis touch slop at SwipeAndMoveTouchListener.java#L138. The touch slop is the distance a touch can wander before we think the user is acting.

A low touch slop for the X-axis makes it is easy to delete alarms but hard to scroll the alarm list. A high value makes it easy to scroll but hard to delete. Finding the right balance is tricky.

On 66513e2 I've increased the slop multiplier from 5 to 7. That did the trick for me but I have to admit I am quite careful and precise with my fingers when scrolling on Boilr.

I've just played a bit more with the multiplier and found that 15 may be a better compromise. Here is a compiled apk with this modification: boilr-0.8.0-rc1.apk.zip. Could you please test it and tell me what you think? Try both to scroll and to delete (swipe).

@dllud dllud removed this from the 1.0.0 milestone Aug 30, 2017
@dllud dllud changed the title Too easy to delete alarms from the list by mistake Delete alarm: add a button, drop swipe move Sep 27, 2017
@dllud dllud added this to the 1.0.0 milestone Sep 27, 2017
@dllud
Copy link
Member

dllud commented Sep 27, 2017

Ok, enough is enough.
@axelsimon is complaining about alarm deletion being too easy, while others at Google Play complain about it being too hard.
I agree with Tomi Koskimäki @ Google Play, the way to go is a delete button. Targeting 720p screens will give us enough space for that. Let's think about how we can redesign the alarm list.

@loziniak
Copy link

I've noticed that when you scroll holding your finger on pair names (left side of the alarm bar), it's harder to accidentally swipe-delete, than when scrolling on the price area. Or maybe it's just a feeling.

@xeverse
Copy link

xeverse commented Jan 7, 2018

This is a really nasty bug.
It's been hunting us for years.
I'm testing that unsigned 0.8.0 apk.
Somewhat better but still they disappear again.

I suggest you remove this nasty swipe completely
and assign that to from the drop down menu or something.

Moreover, the price levels tags to change a bit tiny
(whenever alarm goes off the first response is not to turn it off
but to change the price level and leave it activated)
not fat fingers but hard to tap on them anyway.
You may remove that round thing on the right
(that running timer can be at the bottom line
& tappiping whole stripe can on/off it)
and put larger price tags there. Thanx..

@algazarra
Copy link
Member

algazarra commented Jan 7, 2018

what about this?

5gvkdmz

@xeverse
Copy link

xeverse commented Jan 8, 2018

34655807-e422f1f4-f407-11e7-9247-ce39b2123e1a

top/bot tap edit top bot levels
pair/exch/price area tap can eneable/disable it.
can long tap bring menu with edit/remove/other?
refresh seems to be ok where it its now.
ahhh and to drag move em somehow..

@algazarra
Copy link
Member

I would leave price as view only and between the top and bottom (for the cheaper coins, as it needs lots of screen to show price), as in my first drawing.

I agree to the long tap to bring the edit menu. And tap on exchange/pair for on/off alarms. The alarm is simply greyed out when off.

But the swipe persists... a little X button per alarm would be so win95

@dllud
Copy link
Member

dllud commented Jan 8, 2018

Long tap to show menu is incompatible with drag to move. Choose one.
I prefer drag to move. I see no need for a pop-up menu.

My proposal is way simpler:

  1. Remove the swipe to delete action.
  2. Add a delete button on the top action bar of the Alarm Settings activity (launched when you click the alarm).
  3. Touch nothing else. Iterate later.

a little X button per alarm would be so win95

Agreed.

@xeverse
Copy link

xeverse commented Jan 9, 2018

Kay, fair points.
But can you add plz
larger top & bot price fields
(so one can change em right away)
on the screen which appears
whenever alarm gets triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants