-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete alarm: add a button, drop swipe move #268
Comments
Thanks for the report @axelsimon ! This is an old and known bug that should have been documented here before. The problem lies on the X-axis touch slop at SwipeAndMoveTouchListener.java#L138. The touch slop is the distance a touch can wander before we think the user is acting. A low touch slop for the X-axis makes it is easy to delete alarms but hard to scroll the alarm list. A high value makes it easy to scroll but hard to delete. Finding the right balance is tricky. On 66513e2 I've increased the slop multiplier from I've just played a bit more with the multiplier and found that |
Ok, enough is enough. |
I've noticed that when you scroll holding your finger on pair names (left side of the alarm bar), it's harder to accidentally swipe-delete, than when scrolling on the price area. Or maybe it's just a feeling. |
This is a really nasty bug. I suggest you remove this nasty swipe completely Moreover, the price levels tags to change a bit tiny |
I would leave price as view only and between the top and bottom (for the cheaper coins, as it needs lots of screen to show price), as in my first drawing. I agree to the long tap to bring the edit menu. And tap on exchange/pair for on/off alarms. The alarm is simply greyed out when off. But the swipe persists... a little X button per alarm would be so win95 |
Long tap to show menu is incompatible with drag to move. Choose one. My proposal is way simpler:
Agreed. |
Kay, fair points. |
Hi, I've added a few alarms and now have 6, and they take just slightly more space than can fit on my phone's screen, which means I have to scroll up and down to see them all.
Very often, the alarm under my thumb as I scroll up or down gets deleted, as the slight gesture left or right while going up or down gets registered as a "swipe away" movement to delete the alarm.
Thankfully, it's very easy to undelete an alarm, but the swipe to remove an alarm shouldn't fire so easily I think.
Hope this helps.
The text was updated successfully, but these errors were encountered: