You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This leads to the true timeout duration being 1000x too long. For example leading to dronecan_gui_tool taking over a minute to load when using python-can on a bus without traffic.
Description
When calling
receive
on aPythonCAN
driver, thetimeout
parameter is accidentally multiplied by 1000.pydronecan/dronecan/driver/python_can.py
Line 139 in 19ac176
This leads to the true timeout duration being 1000x too long. For example leading to
dronecan_gui_tool
taking over a minute to load when using python-can on a bus without traffic.Based om the
python-can
driver, it should simply be passed along without changes.https://github.com/hardbyte/python-can/blob/654a02ae24bfc50bf1bb1fad7aab4aa88763d302/can/bus.py#L110-L121
...and it seems to have been like that for at least 7 years 🤔
https://github.com/hardbyte/python-can/blob/6913c4951faba39eb9d9fea2a9f151d60a39d9e0/can/bus.py#L45-L53
Proposed solution
Remove the problematic line
See #78
To reproduce on Debian/Ubuntu:
Which outputs something like
The text was updated successfully, but these errors were encountered: