세션 리스트 아이템에 onair 표시하기 #103 완료 #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pluu
reviewed
Aug 24, 2020
수정 완료했습니다! |
Pluu
requested changes
Aug 25, 2020
| @@ -19,3 +20,12 @@ fun SwipeRefreshLayout.bindRefreshListener(onRefreshListener: SwipeRefreshLayout | |||
|
|
|||
| @BindingAdapter("webUrl") | |||
| fun WebView.bindUrl(value: String?) = value?.let(::loadUrl) | |||
|
|
|||
| @BindingAdapter(value = ["onAir"]) | |||
| fun ImageView.setVisibility(onAir: Boolean) { | |||
There was a problem hiding this comment.
@takedawon
현재 BindingAdapter는 ImageView의 Extension 기능으로도 정의되어 있습니다.
그래서 모든 ImageView가 이 함수를 호출할 수 있습니다.
일반적으로 setVisibility에서 true/false는 VISIBLE/GONE에 해당되기 때문에, 이 경우 onAir라는 표현이 맞지 않아보이네요.
isInvisible 라는 KTX도 존재하므로 BindingAdapter의 네이밍을 더 일반화할 필요가 있어보이네요.
|
@takedawon conflict 처리 부탁드립니다. |
…2020_App into feature/issue/droidknights#103 � Conflicts: � androidapp/app/src/main/java/com/droidknights/app2020/binding/ViewBinding.kt � androidapp/app/src/main/java/com/droidknights/app2020/data/Session.kt � androidapp/app/src/main/res/layout/item_session.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
세션 중 라이브로 진행되는 아이템에 onair 뱃지를 표시합니다.
Session data class에 isLive 를 Boolean값으로 추가합니다.
item_session 에서 tvDate 위쪽에 onair 아이콘을 추가합니다.
Links
Screenshot