[#4] update logic to extract twitter username #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@JNicolao implement reviews left by @danielotieno here - droidconKE/droidconKE2022Web#104 |
manuelgeek
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the checklist below is checked before PR merge, mark if not applicable
PR Checklist
What is the Purpose?
To update logic to get twitter username from both domains x.com and twitter.com
What was the approach?
check if the URL contains either twitter.com or x.com. split the string to extract the username based on which domain is present.
Are there any concerns to addressed further before or after merging this PR?
No
Mentions?
@manuelgeek
Issue(s) affected?
#4