Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Code Quality Gates #14

Open
2 tasks done
hopeman15 opened this issue Mar 24, 2023 · 3 comments
Open
2 tasks done

[FR]: Code Quality Gates #14

hopeman15 opened this issue Mar 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@hopeman15
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem

While putting together a POC for potential asset handling (#13), I noticed we don't have any linting other than the standard android, or any static analysis tools.

Describe the solution

It would be great to align on the quality gates we want to use so as not to have tons of formatting/linting/etc. changes later.

Additional context

I like to use:

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hopeman15 hopeman15 added the enhancement New feature or request label Mar 24, 2023
@tamzi
Copy link
Contributor

tamzi commented Mar 26, 2023

@hopeman15 plan is to create a shared build logic file that creates conventions:
As a nice tip to it:

  • Even have naming conventions and throw it as an error.

see #16

@tamzi
Copy link
Contributor

tamzi commented Mar 26, 2023

This can also exist separately for now 👟

@hopeman15
Copy link
Contributor Author

@tamzi If we prioritize #16 then no need we could potentially ditch this one, or make #16 a milestone and put this under it 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants