Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 as the standard encoding #12

Open
nsoblath opened this issue Mar 9, 2019 · 2 comments
Open

Use UTF-8 as the standard encoding #12

nsoblath opened this issue Mar 9, 2019 · 2 comments

Comments

@nsoblath
Copy link
Member

nsoblath commented Mar 9, 2019

We should use UTF-8 as the encoding for all strings. This will be backwards compatible with our current setup. It will allow international use of dripline. And it's supported by rabbitmq (queue names are UTF-8, for instance).

This will require updates wherever string parsing is done in the C++ library, including a few things in Scarab (e.g. addressing locations in a paramedic hierarchy). We should verify that there's no problem with the YAML library. The JSON library already handles UTF-8.

An external library will be needed for appropriate handling.

@laroque
Copy link
Member

laroque commented Jul 18, 2019

In python 3, strings are all stored as unicode objects, with UTF-8 encoding by default. For dripline 3 work we're developing exclusively in python 3 and so there should be no issues with this. We may need to be careful if we're trying to have legacy python 2 support for this in dripline 2, but it shouldn't be a problem.

I suggest we promote from "proposal" to "proposal accepted" and plan to incorporate this whenever we have someone with the cycles to put it in, perhaps adding it to the dripline 3 release?

@nsoblath
Copy link
Member Author

Everything should be compatible with unicode, with the possible exception of pieces of dripline-cpp. In a future standards release this will be a requirement. See driplineorg/dripline-cpp#39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants