Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Management Policies Needed #1019

Open
rsmets opened this issue Apr 17, 2024 · 1 comment
Open

Change Management Policies Needed #1019

rsmets opened this issue Apr 17, 2024 · 1 comment

Comments

@rsmets
Copy link

rsmets commented Apr 17, 2024

I'm noticing PRs being open and closed with no reviews. Also, the PRs' description content itself is often very sparse or non-existent.

As I noted in a random PR I was looking at:

Wow, I love Drift because I think the engineer work behind it is top notch but I didn't realize that you all allow for PRs to be merged with no review. 😨

I would recommend using gitStream to allow for automated approvals based on conditions (e.g., labels, change content).

I also recommend creating a default PR template that forces authors to provide more contextual information in each PR. You can do that at the Org level, so it applies to all repos' PRs. Here are the github docs on this. It's pretty standard stuff for OS communities.

Please note this recommendations are coming from experience! I'm just looking out for my favorite decentralized perp market. I love what you guys are building - I'm an avid user.

@crispheaney
Copy link
Member

thanks for the feedback! we can do a better job here, will take a look at these tools

for the pr you shared, a contributor review it and gave approval in another chat, which isn't great for people following along

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants