Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag to disable output. Support forms. #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

senglin
Copy link

@senglin senglin commented Apr 13, 2020

While using the library, I found that the I needed the following capabilities which were not supported:

  1. Generate curl requests using form options. (This current throws a String error)
  2. Ability to turn off outputs from http-to-curl.
  3. Bug: Specify url in the Options object is not supported. (This currently logs a curl request of http://localhost/)

Changes:

  1. Added test for new scenario
  2. Convert string to buffer before concatenating the chunks in the body
  3. Added new parameter to turn off console log.
  4. Tidy up some statement. Added comments.

Added test using POST request
@drgx
Copy link
Owner

drgx commented Nov 16, 2020

Sorry for the slow responses, Thanks For your contribution.
Why this library need dockerfile?
Can you please remove the docker file and ignore, then I will merge this PR 🙇

Soon I will help to re-release this patch. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants