Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_network_disconnect_during_migration with big_value_serialization and compression off #4207

Open
kostasrim opened this issue Nov 27, 2024 · 4 comments · May be fixed by #4224
Open

test_network_disconnect_during_migration with big_value_serialization and compression off #4207

kostasrim opened this issue Nov 27, 2024 · 4 comments · May be fixed by #4224
Assignees
@chakaz
Labels
bug Something isn't working

Comments

@kostasrim
Copy link
Contributor

To reproduce check this branch: https://github.com/dragonflydb/dragonfly/actions/runs/12049150090/job/33595305922?pr=4199#step:12:245

and the failure at: https://github.com/dragonflydb/dragonfly/actions/runs/12049150090/job/33595305922?pr=4199#step:12:245

  1. Turn big value serialization to the minum
  2. Turn compression off

Test fails on the CI and it did not fail for me locally. Although to be honest I haven't run it in a loop so maybe it does 🤷‍♂️
@kostasrim kostasrim added the bug Something isn't working label Nov 27, 2024
@kostasrim kostasrim changed the title test_network_disconnect_during_migration fails with test_network_disconnect_during_migration with big_value_serializatio nand compression off Nov 27, 2024
@kostasrim kostasrim changed the title test_network_disconnect_during_migration with big_value_serializatio nand compression off test_network_disconnect_during_migration with big_value_serialization and compression off Nov 27, 2024
@kostasrim
Copy link
Contributor Author

https://github.com/dragonflydb/dragonfly/actions/runs/12055962717/job/33617458972?pr=4073#step:12:772

@kostasrim
Copy link
Contributor Author

kostasrim commented Nov 27, 2024 •
edited
Loading

Also fuzzy migration with serialization=1.

I accumulate those here because they all fall under the same mechanism/flow (value is big, so we serialize it as multiple journal writes)

@kostasrim
Copy link
Contributor Author

and another one https://github.com/dragonflydb/dragonfly/actions/runs/12052270050/job/33619080857?pr=4212#step:12:849

@kostasrim
Copy link
Contributor Author

In total it's 3 different tests from the cluster family. My suspicion is that they all fail because of the same reason so I grouped them here.

@chakaz I hope the 3 tests will be more helpful than one

chakaz added a commit that referenced this issue Nov 28, 2024
@chakaz
fix: Fix test_network_disconnect_during_migration test
a27b000 
There are actually a few failures fixed in this PR, only one of which is
a test bug.

Fixes #4207
@chakaz chakaz linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix test_network_disconnect_during_migration test dragonflydb/dragonfly
2 participants
@chakaz @kostasrim