Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Journal streamer pending_buf_ redundant allocations #4158

Open
adiholden opened this issue Nov 20, 2024 · 0 comments · May be fixed by #4225
Open

Journal streamer pending_buf_ redundant allocations #4158

adiholden opened this issue Nov 20, 2024 · 0 comments · May be fixed by #4225
Assignees
@BorysTheDev
Labels
enhancement New feature or request minor nice to have enhancement

Comments

@adiholden
Copy link
Collaborator

When calling JournalStreamer::Write if there is a write request in flight we resize the pending_buf_ leading to redundant allocations and copies.
Can we use iovec instead calling resize every time?
@adiholden adiholden added the enhancement New feature or request label Nov 20, 2024
@romange romange added the minor nice to have enhancement label Nov 20, 2024
@BorysTheDev BorysTheDev linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BorysTheDev BorysTheDev

Labels
enhancement New feature or request minor nice to have enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove redundant allocations for streamer dragonflydb/dragonfly
3 participants
@romange @BorysTheDev @adiholden