[wip -- do not review] feat: add support for big values in SeederV2 #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
kostasrim
commented
Nov 28, 2024
| @@ -137,6 +138,8 @@ def __init__( | |||
| data_size=100, | |||
| collection_size=None, | |||
| types: typing.Optional[typing.List[str]] = None, | |||
| huge_value_percentage=0, | |||
There was a problem hiding this comment.
For now I will keep a flat probability for each key in the key target to contain a huge value
kostasrim
commented
Nov 28, 2024
| local elements = dragonfly.randstr(LG_funcs.esize, LG_funcs.csize) | ||
| local elements | ||
| if huge_entry() then | ||
| -- Hard coded 10 here, meaning up to 10 huge entries per set |
There was a problem hiding this comment.
//TODO so I don't forget to fix it. Replace 10 with LG_funcs.csize()
kostasrim
commented
Nov 28, 2024
| @@ -85,6 +88,7 @@ while true do | |||
| if counter % 10 == 0 then | |||
| -- calculate intensity (not normalized probabilities) | |||
| -- please see attached plots in PR to undertand convergence | |||
| -- https://github.com/dragonflydb/dragonfly/pull/2556 | |||
There was a problem hiding this comment.
took me a few seconds to find this so I thought I should include the link. Now we can jump straight to the pr if needed (and it will be needed for anyone who changes this code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4157
//TODO add tests