Logseq 0.10.5 breaks the theme

[k7hpn]

Upgrading to Logseq 0.10.5 (changelog) seems to break the theme. Text is now black on the Dracula background color.

[pekcheey]

I think it is broken by Logseq 0.10.4.

[rawwave]

I'm seeing this too and had to switch to the default dark theme. The menu for the graphs turns transparent. I'm seeing the issue on 0.10.5 for macOS, iOS, Windows and Linux. So it seems to be a fundamental change/issue. I can also confirm it does NOT happen on 0.10.3, so it's a recent change.

[Jov03]

Facing the same issue after upgrading to 0.10.5. Had to roll back to 0.9.20 for it to work again.

Theme used : logseq-monokai : https://github.com/tzcl/logseq-monokai

[k7hpn]

Facing the same issue after upgrading to 0.10.5. Had to roll back to 0.9.20 for it to work again.

Theme used : logseq-monokai : https://github.com/tzcl/logseq-monokai

It appears that theme is having the same issue.

[k7hpn]

Looks like there's a Logseq issue for this as well.

[rawwave]

@k7hpn - Great link to the Logseq Issue... there is a comment there that recommends forcing an "accent" color and that helped fix the Dracula theme for me....

logseq/logseq#10873 (comment)

[zen010101]

me too.

[rawwave]

Does anyone know if this is being looked at? I see there was an update to the README.md talking about it but not sure if anyone is actively working on it. I'm not trying to push for something as I'm guessing this is all volunteer, I just wanted to understand if it is worth trying to look at this over the weekend or if someone with much more knowledge and history with this project is about to fix this with 2 hrs of effort.

[rigzba21]

I just tried the workaround forcing an "accent" color from logseq/logseq#10873 (comment) and it seems to mostly fix/work for Logseq 0.10.6, although some of the colors still seem off.

[SamKr]

I love the addition of the word yet 😁 Would be awesome if this could be fixed for the latest version ❤️

[k7hpn]

This seems to be working today in Logseq 0.10.8

[PixelTux]

I confirm that with the theme installed post-upgrade from Logseq 0.10.7 to 0.10.8 the theme was working. However, after I removed and reinstall it, it stopped to working. @k7hpn, if you have a moment, could you please try removing and reinstalling the theme to see if the issue persists on your end?

[k7hpn]

Ahh, @PixelTux I think I had inadvertently selected an accent color which fixed it. When I deselect the accent color it is still broken. Sorry about that, that's on me.

[SlyBouhafs]

I merged this fix #24 which is supposed to fix the issue, can you guys confirm that it is fixed?

[cg-o]

@SlyBouhafs I tested both on 0.10.7 and 0.10.8, it works for me! But I had to manually copy this repos custom.css. It seems neither the marketplace version nor the cdn link have been updated?

[zen010101]

I merged this fix #24 which is supposed to fix the issue, can you guys confirm that it is fixed?

It works with 0.10.8! Great!

[AristarhSamos]

On Logseq 10.8, the theme does not work through the theme's plugin. It works if you register it in custom.css. But the color of the links and dates has changed from pink to cyan. On version 10.3, the theme from the plugin and from custom.css works and the colors are correct there, with pink highlighting of links and other data.
The right sidebar changes colors slightly to darker shades of gray.
So far, we have to stay on version 10.3, where the theme works as needed.

[PixelTux]

Hi @AristarhSamos , you're seeing cyan instead of pink because it's actually defined in the code.

Not sure if it's intended or a bug, but if you prefer pink, you can go to
Settings > General > Custom Theme and click on Edit custom.css
add this to overwrite the theme colore:

.external-link {
  color: var(--pink);
}

.external-link:hover {
  color: var(--pink-hover);
}

Remember to remove it if you change themes, as it will default back to white since the --pink color is specific to this theme and isn't universally defined.

[alexbraga]

I've manually copied and pasted the custom.css on version 10.0.8 and it seems to be working fine. The only broken thing that I noticed until now were the drop-down menus. Either the background color or the text color must be changed but I failed to find the corresponding CSS rule for that.

[dev0T]

I am having the same issue with the theme installed from the Marketplace. I got it running by following the old instructions but I am also having the same dropdown issue as @alexbraga

[PixelTux]

@alexbraga @dev0T this bug originates from the upstream main build when an accent color is not selected and the dark theme is used. I'll look into it when I have some time.

[cballenar]

After some testing this seems to be caused by how the variables are set when data-theme=dark is used.

This can be fixed by changing how variables are defined from :root to:

html.dark,
html[data-theme=dark] {
...

It seems the data-theme will be applied anyway and other styles are applied on top. So we need to set these variables at least at that level. Can someone help confirm?

I'll submit a PR shortly for review.

[cballenar]

It's also worth pointing out that recent versions of logseq that introduce accent colors are not fully compatible with this theme. They introduce additional variables (like -grays) that overwrite other styles used by this theme.

At this point we could only recommend using it WITHOUT any accent colors. 😕

[k7hpn]

I received a notification that the upstream (LogSeq) bug regarding this is set to be closed due to inactivity so I revisited the situation. Uninstalling and reinstalling the Dracula theme today in LogSeq v0.10.9 (c67b8b5) still results in black-on-dark-grey text for me if I do not have an accent color selected.