Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_magic_imputation to make setting small values to 0 optional #153

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

jordanc17
Copy link
Contributor

These changes keep the default behavior of run_magic_imputation the same while allowing users to select if the matrix will be made sparse and the threshold that will be used to set small values to zero.

@katosh
Copy link
Collaborator

katosh commented Nov 26, 2024

Thank you @jordanc17! This change makes the clipping optional without breaking old behavior.

I made some additions in b0f949e to make the matrix a proper sparse matrix. This additional change breaks old behavior in the case when a dense X is supplied and sparse=True. While the values are the same it now converts the resulting sparse matrix into a sparse format. @ManuSetty

@katosh katosh merged commit 4d0f031 into dpeerlab:master Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants