Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Missing undefined check in user component #662

Open
ghost opened this issue Dec 16, 2022 · 0 comments
Open

BUG: Missing undefined check in user component #662

ghost opened this issue Dec 16, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Dec 16, 2022

this.user?.name cause the getter fetch the undefined this.firstName.slice(0, 11);

user-icon.component.ts

get initials(): string {
   const result = this.user?.name != null ? this.user.name.split(' ') : '  ';
   return result.length > 1 ? `${result[0][0]}${result[1][0]}`.toUpperCase() : '  ';
 }

user.ts

  public get name(): string {
    const fn = this.firstName.slice(0, 11);
    const sn = this.lastName.slice(0, 11);
    const nn = this.nickname && this.nickname.trim() ? ` (${this.nickname.trim().slice(0, 11)})` : '';
    return `${fn} ${sn}${nn}`;
  }

image

I will fix that in this pull later #661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants