Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python>3.10 is not represented in pyproject.toml #234

Closed
davidberenstein1957 opened this issue Aug 16, 2023 · 2 comments · Fixed by #240
Closed

python>3.10 is not represented in pyproject.toml #234

davidberenstein1957 opened this issue Aug 16, 2023 · 2 comments · Fixed by #240
Labels
bug

Comments

@davidberenstein1957
Copy link

python match-case statement forces package to be python>3.10
@davidberenstein1957
Copy link
Author

Not sure if it is better to slightly rewrite the code and allow for python>=3.8 or to update the pyproject.toml.

@davidberenstein1957 davidberenstein1957 mentioned this issue Aug 16, 2023
Closed
@rlouf
Copy link
Member

rlouf commented Aug 16, 2023

See my reply in #219 for the Python version. But yes, pyproject.toml should be updated.

@rlouf rlouf changed the title [BUG] python>3.10 is not represented in pyproject.toml python>3.10 is not represented in pyproject.toml Aug 16, 2023
@rlouf rlouf added the bug label Aug 16, 2023
@rlouf rlouf mentioned this issue Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make transformers dependency explicit rlouf/outlines
2 participants
@rlouf @davidberenstein1957