-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code fix 1678 #1704
Code fix 1678 #1704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, otherwise looks good!
dotnet-desktop-guide/framework/wpf/advanced/snippets/threading-model/csharp/App.xaml.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/framework/wpf/advanced/snippets/threading-model/csharp/AssemblyInfo.cs
Show resolved
Hide resolved
dotnet-desktop-guide/framework/wpf/advanced/snippets/threading-model/csharp/Weather.xaml.cs
Show resolved
Hide resolved
dotnet-desktop-guide/framework/wpf/advanced/snippets/threading-model/csharp/Weather.xaml.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/framework/wpf/advanced/snippets/threading-model/csharp/Weather.xaml.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/framework/wpf/advanced/snippets/threading-model/csharp/MultiWindow.xaml.cs
Show resolved
Hide resolved
Co-authored-by: David Pine <[email protected]>
Hi @adegeo , but Task.Run is not used in the description nor in the code. |
@Micke3rd Ack yes... And some other variables were changed via the feedback that weren't changed in the description. I'll run through the article and fix these up. |
regardless of this typo, thank you especially for the samples\wpf\Threading\MultithreadedWindow example, didn't know this is possible. |
InvokeAsync
instead ofBeginInvoke
.Fixes #1691
Fixes #1678
Internal previews