Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A warning should be provided if there are unexpected properties defined in yaml #700

Open
caaavik-msft opened this issue Feb 15, 2024 · 0 comments

Comments

@caaavik-msft
Copy link
Contributor

We recently have added some new features to the yaml schema (e.g. beforeJob, sources) which will change the way that the crank controller loads and reads the crank yaml file. It would be good if the controller is able to check if the yaml contains any properties which it does not know about to tell the user that they may need to update their crank controller so that it can handle these properties correctly.

This change can be done by updating the benchmarks.schema.json to the latest version of the schema and ensuring that we always keep it up to date going forwards whenever we update the yaml. We would then need to change the validation code that uses this schema to display a warning if it sees any unexpected properties.

As a further extension point, we could also make the crank controller make a query to nuget to see if a new version of crank exists to tell people if a new one exists and how to upgrade to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant