Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve start/stop/restart command notifications #6224

Open
1 task done
JamesNK opened this issue Oct 10, 2024 · 0 comments · May be fixed by #6625
Open
1 task done

Improve start/stop/restart command notifications #6224

JamesNK opened this issue Oct 10, 2024 · 0 comments · May be fixed by #6625
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Oct 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

A command to start/stop/restart a resource involves:

  1. Dashboard sending command to the app host. For example, a command to stop a resource.
  2. App host sends a request to DCP to perform an action.
  3. DCP queues this action and then returns back to the app host.
  4. App host returns back to the dashboard that there was a success.

The problem is the app host doesn't wait for the resource to actually change to the desired state before returning a response to the dashboard. The resource could still be stopping and stop after the dashboard reports success. Or the resource might not be stopped because of a problem inside DCP, but the dashbaord has already reported success.

Describe the solution you'd like

The app host waits for a resource to enter the desired state before returning a success/fail result to the dashboard.

If starting a resource fails, that's reported as a failure to the dashboard.
If something hangs, then after a timeout (20 seconds?) that's reported as a timeout to the dashboard.

Additional context

No response

@JamesNK JamesNK added enhancement area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Oct 10, 2024
@joperezr joperezr added the untriaged New issue has not been triaged label Oct 15, 2024
@davidfowl davidfowl removed enhancement untriaged New issue has not been triaged labels Oct 16, 2024
@davidfowl davidfowl added this to the Backlog milestone Oct 22, 2024
@JamesNK JamesNK linked a pull request Nov 7, 2024 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants