Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a Channel Back to Its Original Name Causes Blinking #1

Open
dotMavriQ opened this issue Oct 3, 2024 · 0 comments
Open

Renaming a Channel Back to Its Original Name Causes Blinking #1

dotMavriQ opened this issue Oct 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dotMavriQ
Copy link
Owner

dotMavriQ commented Oct 3, 2024

bug.mp4

Description

When a renamed channel is reverted back to its original name using Slacktack, the channel name blinks rapidly in the sidebar. This behavior persists as long as the override is present.

Steps to Reproduce

  1. Open the Slacktack popup and rename a channel (e.g., "general" to "team-chat").
  2. Save the new name override.
  3. Rename the same channel back to its original name (e.g., change "team-chat" back to "general").
  4. Observe the channel name in the Slack sidebar.

Expected Behavior

The channel name should display smoothly without blinking, whether it’s being reverted to its original name or any other custom name.

Actual Behavior

The channel name blinks rapidly, causing a visual glitch in the sidebar.

Additional Information

  • Browser: Chrome 129
  • Slacktack Version: 0.8 Beta
  • Operating System: macOS 10.15.7
  • Browser Size: 1512 x 823
  • Screen Size: 1512 x 982 (Retina)
  • Color Depth: 30 bit

Possible Cause

This may be caused by a conflict in the MutationObserver when the channel's name in the sidebar matches both the original name and the stored override.

Suggested Solution

Investigate how the MutationObserver handles name changes and adjust the logic to prevent blinking when a channel is renamed to its original name.

@dotMavriQ dotMavriQ added the bug Something isn't working label Oct 3, 2024
@dotMavriQ dotMavriQ self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant