Fix ADP1

dortania · Mar 16, 2020 · 3b3a368 · 3b3a368
1 parent 52a793f
commit 3b3a368
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/clover-conversion/Clover-boot-arg.md b/clover-conversion/Clover-boot-arg.md
@@ -29,6 +29,15 @@ This list is based of memory and an annoyed self with seeing these flags keep po
 
 For some reason people kept using these flags into Clover which had no effect, and so we really need to stop the train on this one with OpenCore
 
-**GraphicsEnabler=No**
+**PCIRootUID=Value**
+
+* This sets the `_UID` of `Device (PCI0)` to whatever the value is, supposedly needed on legacy AMD GPUs but this is debatable. Ironically Clover still uses this flag but most users know it from Chameleon. [Source](https://github.com/CloverHackyColor/CloverBootloader/blob/81f2b91b1552a4387abaa2c48a210c63d5b6233c/rEFIt_UEFI/Platform/FixBiosDsdt.cpp#L1630-L1674)
+
+**GraphicsEnabler=Yes/No**
+
+* No clue tbh, InjectAMD/Nvidia was the Clover equivlant but no feature parity in OpenCore besides running [WhateverGreen](https://github.com/acidanthera/WhateverGreen)
+
+**IGPEnabler=Yes/No**
+
+* Same idea as GraphicsEnabler, Clover equivlant is InjectIntel so feature parity would be [WhateverGreen's Framebuffer patching](https://github.com/acidanthera/WhateverGreen/blob/master/Manual/FAQ.IntelHD.en.md)
 
-**IGPEnabler=Yes**
diff --git a/clover-conversion/Clover-config.md b/clover-conversion/Clover-config.md
@@ -17,7 +17,7 @@ So with the transition from Clover to OpenCore we should start removing unneeded
 * EHCI Patches: Recommeneded to power off the controller with [SSDT-EHCx_OFF](https://github.com/acidanthera/OpenCorePkg/blob/master/Docs/AcpiSamples/SSDT-EHCx_OFF.dsl). Skylake and newer users do not have an EHCI controller so no need for this.
    * change EHC1 to EH01
    * change EHC2 to EH02
-* XHCI Patches: Not needed anymore, recommended to make an [Injector kext](https://github.com/corpnewt/USBMap) instead to kick out the built-in injectors
+* XHCI Patches: Not needed once an [Injector kext](https://github.com/corpnewt/USBMap) is made
    * change XHCI to XHC
    * change XHC1 to XHC
 * SATA patches: Purely cosmetic in macOS now
@@ -42,9 +42,9 @@ So with the transition from Clover to OpenCore we should start removing unneeded
    * change HDAS to HDEF
    * change CAVS to HDEF
    * change AZAL to HDEF
-* Z390 BIOS RTC bug fix: See here on best solution: [Getting started with ACPI](https://khronokernel.github.io/Getting-Started-With-ACPI/)
+* Z390 BIOS RTC bug fix: See here on best solution: [Getting started with ACPI](https://khronokernel.github.io/Getting-Started-With-ACPI/)(SSDT-AWAC)
    * change STAS to [Blank]
-* NVMe patches: NVMeFix.kext fixes power management
+* NVMe patches: [NVMeFix](https://github.com/acidanthera/NVMeFix) fixes power management
    * change PXSX to ANS1
    * change PXSX to ANS2
 * Other purely consmetic patches:
@@ -55,6 +55,7 @@ So with the transition from Clover to OpenCore we should start removing unneeded
    * change PIC to IPIC
    * change GBE1 to ETH0
 
+
 **Patches**
 
 * TgtBridge patches: No feature parity in OpenCore, see comments(TgtBridge was very buggy in Clover):
@@ -95,7 +96,8 @@ So with the transition from Clover to OpenCore we should start removing unneeded
 
 * **FixADP1**:
    * Renames device `AC0_` to `ADP1`, see [Rename-SSDT](https://github.com/khronokernel/Opencore-Vanilla-Desktop-Guide/blob/master/extra-files/Rename-SSDT.dsl) for an example
-
+* Also injects `Name (_PRW, Package (0x02) {0x1C,0x03})` into the device if not present. [Source](https://github.com/CloverHackyColor/CloverBootloader/blob/81f2b91b1552a4387abaa2c48a210c63d5b6233c/rEFIt_UEFI/Platform/FixBiosDsdt.cpp#L1677-L1692)
+
 * **FixRTC**:
    * CorpNewt's [SSDTTime](https://github.com/corpnewt/SSDTTime) to make the proper SSDT, `FixHPET - Patch out IRQ Conflicts`
 * **FixTMR**: