Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from python-jose to pyjwt #42

Open
siebediels opened this issue Apr 30, 2024 · 5 comments
Open

Switch from python-jose to pyjwt #42

siebediels opened this issue Apr 30, 2024 · 5 comments

Comments

@siebediels
Copy link

Is there a plan to migrate from python-jose to pyjwt? Python-jose isn't maintained any more and contains some known vulnerabilities.

I noticed that there was some effort done in #41 , but not sure what happened to it. As an intermediate solution, we could perhaps move to python-jose[cryptography] which is already recommended above the default python-jose (with Python backend)?

@spawn-guy
Copy link

spawn-guy commented Sep 10, 2024

@siebediels i just tested locally these modifications in #41 and they just work out-of-the-box.

there could be some improvements regarding Pydantic-v2 but otherwise looks working (with valid tokens)

i'd just merge that one PR and go ahead

@spawn-guy
Copy link

spawn-guy commented Sep 11, 2024

if needed - i can make a PR. for now i have a working local version of code. just ask ;)

@spawn-guy
Copy link

aaight... lezz do this #43

@spawn-guy
Copy link

i've made some updates and some more fixes to the PR. enforced some verifications by default, unless a developer overrides them explicitly.
now - i like it. lets wait for the @dorinclisu to come back to us

additionally, i'd like to remove the email namespace parsing. to get the email you need to call Auth0Management API directly. i think. also this is private data leak if one includes the email in tokens (so be careful)

@spawn-guy
Copy link

bump.

unfortunately, no activity on my PR :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants