Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request or Bug] ... #1

Open
dongjin-na opened this issue Jul 23, 2024 · 0 comments
Open

[Request or Bug] ... #1

dongjin-na opened this issue Jul 23, 2024 · 0 comments
Labels

Comments

@dongjin-na
Copy link
Owner

Details

Describe the bug
In general, data flow in CB between Data Movement Kernel (DMVK) and Compute Kernel is as follows.

cb_flow1 drawio (1)
Fig.1 Data Flow in CB between Data Movement Kernel and Compute Kernel

While implementing the operation, we encountered a hang issue at the seventh step of the cb_reserve_back API when the pop and push operations were repeatedly executed within the compute kernel, as shown in the diagram below.
cb_flow2 drawio
Fig.2 Detailed Data Flow and Loop in Compute Kernel

I have added test code in the hang_in_compute_kernel branch by slightly modifying moreh_sum code.

The sequence appears to be correct, but we need to verify if this kernel implementation violates any guidelines or if it is indeed a bug.

To Reproduce
Steps to reproduce the behavior:

  1. git checkout origin/hang_in_compute_kernel
  2. CONFIG=Debug ./build_metal.sh
  3. export TT_METAL_DPRINT_CORES=0,0
  4. pytest tests/tt_eager/python_api_testing/unit_testing/misc/test_moreh_sum.py::test_compute_kernel_hang

Expected behavior
No kernel hang occurs.

Screenshots
If applicable, add screenshots to help explain your problem.

$ pytest tests/tt_eager/python_api_testing/unit_testing/misc/test_moreh_sum.py::test_compute_kernel_hang

 ......

loop 0 / 8
before cb_reserve_back
after cb_reserve_back
loop 1 / 8
before cb_reserve_back
after cb_reserve_back
loop 2 / 8
before cb_reserve_back

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant