Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CLI should warn if passed invalid arguments #96

Open
1 of 5 tasks
matthewp opened this issue Jan 18, 2018 · 0 comments
Open
1 of 5 tasks

The CLI should warn if passed invalid arguments #96

matthewp opened this issue Jan 18, 2018 · 0 comments

Comments

@matthewp
Copy link
Contributor

@imaustink commented on Mon Sep 18 2017

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:
Running invalid commands exits without any warning. In my opion, this should at least output help.

Steps to reproduce:
Run donejs app add some-app.

donejs-cli-no-error

Expected results:
The CLI logs a warning or help.

Actual results:
The CLI exits silently.

Environment:

Software Version
donejs -V 1.0.1
node -v 8.4.0
npm -v 5.3.0
Operating system Mac OS 10.12.6

@matthewp commented on Thu Jan 18 2018

Hey @imaustink, sorry for taking so long to reply. So, what donejs actually does it defer to donejs-cli. donejs-cli will look in node_modules/.bin/ and then package.json's .scripts, for, in this case app. So the fact that it doesn't warn when it finds something is something we can (hopefully) fix in donejs-cli. Going to move this issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant