Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ill vertical alignment #287

Open
memeplex opened this issue Oct 8, 2021 · 3 comments
Open

Ill vertical alignment #287

memeplex opened this issue Oct 8, 2021 · 3 comments

Comments

@memeplex
Copy link

memeplex commented Oct 8, 2021

When using all-the-icons with company-box and doom-modeline I'm seeing lots of alignment problems, some of which are really bad:

The icons in company-box-icons-all-the-icons come annotated with (raise -0.24), which is probably related to the issue, but this is not something company-box is doing AFAICS, but the way they are returned, already instrumented that way, by all-the-icons.

image

@memeplex
Copy link
Author

memeplex commented Oct 8, 2021

I can fix the company-box issue by setting all-the-icons-default-adjust to 0 (default was -0.2). That's fine but it's still a global setting and I'm not sure I'm not breaking anything else, so what's the rationale to set it at -0.2 by default? Is it in order to compensate the default scale factor of 1.2? If that's the case it's not working properly.

OTOH the issue with doom modeline wasn't fixed by changing the default adjust. I have a couple of doubts then: is that first file icon coming from all-the-icons? If it is, then is it unaffected by all-the-icons-default-adjust because doom-modeline is doing its own thing on top of this?

@seagle0128
Copy link
Contributor

seagle0128 commented Oct 10, 2021

In fact, both in all-the-icons and doom-modeline, there are many hardcoded values for :v-adjust. It's hard to align all icons. all-the-icons-default-adjust only impacts some icons, since the most of icons have set :v-adjust.

@memeplex
Copy link
Author

memeplex commented Oct 10, 2021

Yes, I known it's a PITA. I hope with svg enabled by default in emacs different projects in the community may agree on at least one consistent svg icon set that can be included as part of all-the-icons. I suggested elsewhere using the vscode ones available in https://github.com/microsoft/vscode-icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants