Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary #26

Closed
juliangruber opened this issue May 16, 2013 · 8 comments
Closed

binary #26

juliangruber opened this issue May 16, 2013 · 8 comments

Comments

@juliangruber
Copy link
Contributor

[15:50:41] actually I think binary mode should be the default
[15:50:55] as a "real" stream/transport/socket supports binary
[15:51:42] currently multilevel requires a binary capable stream, and i need to make an option {binary:false}, in which case it should encode buffers as base64 or anything else that behaves well
[16:12:36] juliangruber: yes, I'd be happy to merge that -

will do

@AaronO
Copy link

AaronO commented Aug 30, 2013

Any updates on this ?

I currently need this given that I'm doing nested multiplexing (mux-demux on top of another mux-demux stream) as well as transporting binary data.

Is there a decent workaround I could use in the meantime ?

Thanks

@nakosung
Copy link

+1

@juliangruber
Copy link
Contributor Author

This is fixed!

  • require('mux-demux/jsonb') works over non binary capable transports and base64-encodes binary data
  • require('mux-demux/msgpack') works only over binary capable transports and is more effective

@dominictarr
Copy link
Owner

be warned though, that jsonb is base64's the data, so it expands. this is necessary when using with shoe/sockjs
because binary is not yet supported. see: sockjs/sockjs-protocol#74

@nakosung
Copy link

nakosung commented Sep 2, 2013

What about binary.js? It seems to offer better performance. 'mux-demux/binarypack' :)

    1. 1., 오후 9:35, Dominic Tarr [email protected] 작성:

be warned though, that jsonb is base64's the data, so it expands. this is necessary when using with shoe/sockjs
because binary is not yet supported. see: sockjs/sockjs-protocol#74


Reply to this email directly or view it on GitHub.

@dominictarr
Copy link
Owner

@nakosung I would certainly merge a pull request adding binary-pack encoding!

@dominictarr
Copy link
Owner

would be great to see perf difference between it and msgpack

@nakosung
Copy link

nakosung commented Sep 4, 2013

FYI, unfortunately, I'm not in a hurry with new binary.js thing for now. Maybe months later I will need 'the better performance'. Currently I'm happy with utf-8 stream for prototyping.

    1. 2., 오후 5:22, Dominic Tarr [email protected] 작성:

would be great to see perf difference between it and msgpack


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants