-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binary #26
Comments
Any updates on this ? I currently need this given that I'm doing nested multiplexing (mux-demux on top of another mux-demux stream) as well as transporting binary data. Is there a decent workaround I could use in the meantime ? Thanks |
+1 |
This is fixed!
|
be warned though, that jsonb is base64's the data, so it expands. this is necessary when using with shoe/sockjs |
What about binary.js? It seems to offer better performance. 'mux-demux/binarypack' :)
|
@nakosung I would certainly merge a pull request adding binary-pack encoding! |
would be great to see perf difference between it and msgpack |
FYI, unfortunately, I'm not in a hurry with new binary.js thing for now. Maybe months later I will need 'the better performance'. Currently I'm happy with utf-8 stream for prototyping.
|
[15:50:41] actually I think binary mode should be the default
[15:50:55] as a "real" stream/transport/socket supports binary
[15:51:42] currently multilevel requires a binary capable stream, and i need to make an option {binary:false}, in which case it should encode buffers as base64 or anything else that behaves well
[16:12:36] juliangruber: yes, I'd be happy to merge that -
will do
The text was updated successfully, but these errors were encountered: