Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not milliseconds? #13

Open
angelcervera opened this issue May 21, 2015 · 2 comments
Open

Why not milliseconds? #13

angelcervera opened this issue May 21, 2015 · 2 comments

Comments

@angelcervera
Copy link

Why not milliseconds? :(

@igitur
Copy link

igitur commented May 21, 2015

Because you haven't submitted your pull request yet.

@jochemstoel
Copy link

jochemstoel commented Nov 14, 2019

I would too be interested in the support for milliseconds. Other than that this little package is just what I need. Nice and simple. I realize this repository hasn't been updated in 5 years and yes I know it should not be that difficult to add it and do a pull request but I had a quick look at the code and at first sight it is not trivial enough to do myself. Seems faster to rewrite it from scratch.

Probably easier for the person who actually wrote it anyway. Support for milliseconds also means I would like the parse method to return milliseconds and not seconds. Maybe add a second option(s) argument to juration.parse to set the return value unit. (ms, sec, or even hours days weeks) I dunno, up to you.

If you feel like it and you have the time, thank you.

Never mind, I found this. parse-duration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants